[GitHub] rafaelweingartner commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.
URL: https://github.com/apache/cloudstack/pull/3036#discussion_r236483213
 
 

 ##########
 File path: api/src/main/java/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java
 ##########
 @@ -59,6 +59,15 @@ public void execute() {
         response.setKVMSnapshotEnabled((Boolean)capabilities.get("KVMSnapshotEnabled"));
         response.setAllowUserViewDestroyedVM((Boolean)capabilities.get("allowUserViewDestroyedVM"));
         response.setAllowUserExpungeRecoverVM((Boolean)capabilities.get("allowUserExpungeRecoverVM"));
+
+        response.setVmSnapshotsMax((Integer)capabilities.get("vmsnapshotsmax"));
 
 Review comment:
   What about extracting these names to enum? and then documenting the option/names to better explain what they mean.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services