You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Yifan Gu <yi...@mesosphere.io> on 2014/06/12 21:15:46 UTC
Re: Review Request 22472: Fixed SlaveTest.TerminatingSlaveDoesNotReregister
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22472/
-----------------------------------------------------------
(Updated June 12, 2014, 7:15 p.m.)
Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
Summary (updated)
-----------------
Fixed SlaveTest.TerminatingSlaveDoesNotReregister
Bugs: MESOS-1460
https://issues.apache.org/jira/browse/MESOS-1460
Repository: mesos-git
Description
-------
Ignored subsequent status updates.
Muted warnings by catching mock calls.
Diffs
-----
src/tests/slave_tests.cpp 2c8f183
Diff: https://reviews.apache.org/r/22472/diff/
Testing
-------
make check
Thanks,
Yifan Gu
Re: Review Request 22472: Fixed SlaveTest.TerminatingSlaveDoesNotReregister
Posted by Benjamin Mahler <be...@gmail.com>.
Committed, please subscribe to commits@mesos.apache.org so you can get the
commit emails, if you haven't already!
On Thu, Jun 12, 2014 at 12:24 PM, Ben Mahler <be...@gmail.com>
wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22472/#review45524
> -----------------------------------------------------------
>
> Ship it!
>
>
> Ship It!
>
> - Ben Mahler
>
>
> On June 12, 2014, 7:15 p.m., Yifan Gu wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/22472/
> > -----------------------------------------------------------
> >
> > (Updated June 12, 2014, 7:15 p.m.)
> >
> >
> > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
> >
> >
> > Bugs: MESOS-1460
> > https://issues.apache.org/jira/browse/MESOS-1460
> >
> >
> > Repository: mesos-git
> >
> >
> > Description
> > -------
> >
> > Ignored subsequent status updates.
> > Muted warnings by catching mock calls.
> >
> >
> > Diffs
> > -----
> >
> > src/tests/slave_tests.cpp 2c8f183
> >
> > Diff: https://reviews.apache.org/r/22472/diff/
> >
> >
> > Testing
> > -------
> >
> > make check
> >
> >
> > Thanks,
> >
> > Yifan Gu
> >
> >
>
>
Re: Review Request 22472: Fixed SlaveTest.TerminatingSlaveDoesNotReregister
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22472/#review45524
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On June 12, 2014, 7:15 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22472/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 7:15 p.m.)
>
>
> Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1460
> https://issues.apache.org/jira/browse/MESOS-1460
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Ignored subsequent status updates.
> Muted warnings by catching mock calls.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 2c8f183
>
> Diff: https://reviews.apache.org/r/22472/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Yifan Gu
>
>