You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/29 02:02:46 UTC
[GitHub] [spark] TongWeii opened a new pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
TongWeii opened a new pull request #34430:
URL: https://github.com/apache/spark/pull/34430
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Support SparkSQL use IN/EXISTS with subquery in Project/Aggregate
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently, user runs the following code will report an error.
```
CREATE TABLE tbl1 (col1 INT, col2 STRING) USING PARQUET;
INSERT OVERWRITE TABLE tbl1 SELECT 0,1;
CREATE TABLE tbl2 (c1 INT, c2 STRING) USING PARQUET;
INSERT OVERWRITE TABLE tbl2 SELECT 0,2;
case 1:
select c1 in (select col1 from tbl1) from tbl2
Error msg:
IN/EXISTS predicate sub-queries can only be used in Filter/Join and a few commands: Project []
case 2:
select count(1), case when c1 in (select col1 from tbl1) then "A" else "B" end as tag from tbl2 group by case when c1 in (select col1 from tbl1) then "A" else "B" end
Error msg:
IN/EXISTS predicate sub-queries can only be used in Filter/Join and a few commands: Aggregate []
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Now, user can run following code correctly
```
case 1:
select c1 in (select col1 from tbl1) from tbl2
case 2:
select count(1), case when c1 in (select col1 from tbl1) then "A" else "B" end as tag from tbl2 group by case when c1 in (select col1 from tbl1) then "A" else "B" end
### How was this patch tested?
Added unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TongWeii commented on pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
Posted by GitBox <gi...@apache.org>.
TongWeii commented on pull request #34430:
URL: https://github.com/apache/spark/pull/34430#issuecomment-954350302
@AngersZhuuuu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on pull request #34430:
URL: https://github.com/apache/spark/pull/34430#issuecomment-956583134
Looks like this PR only relaxed the constraints in CheckAnalysis, but didn't add support for handling correlated IN/EXISTS subqueries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TongWeii closed pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
Posted by GitBox <gi...@apache.org>.
TongWeii closed pull request #34430:
URL: https://github.com/apache/spark/pull/34430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34430:
URL: https://github.com/apache/spark/pull/34430#issuecomment-954363217
ping @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #34430:
URL: https://github.com/apache/spark/pull/34430#issuecomment-954435361
Few days ago I opened very similar pull request: #34402 . It is still WIP because I would like to improve its test coverage a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TongWeii closed pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
Posted by GitBox <gi...@apache.org>.
TongWeii closed pull request #34430:
URL: https://github.com/apache/spark/pull/34430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on pull request #34430:
URL: https://github.com/apache/spark/pull/34430#issuecomment-956583134
Looks like this PR only relaxed the constraints in CheckAnalysis, but didn't add support for handling correlated IN/EXISTS subqueries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34430:
URL: https://github.com/apache/spark/pull/34430#issuecomment-954355208
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on pull request #34430:
URL: https://github.com/apache/spark/pull/34430#issuecomment-956583134
Looks like this PR only relaxed the constraints in CheckAnalysis, but didn't add support for handling correlated IN/EXISTS subqueries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk edited a comment on pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
Posted by GitBox <gi...@apache.org>.
tanelk edited a comment on pull request #34430:
URL: https://github.com/apache/spark/pull/34430#issuecomment-954435361
Few days ago I opened very similar pull request: #34402 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] TongWeii closed pull request #34430: [SPARK-37131][SQL] Support use IN/EXISTS with subquery in Project/Aggregate
Posted by GitBox <gi...@apache.org>.
TongWeii closed pull request #34430:
URL: https://github.com/apache/spark/pull/34430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org