You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2014/09/17 14:49:10 UTC

[GitHub] incubator-brooklyn pull request: REST API Shutdown improvements

GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/172

    REST API Shutdown improvements

    Implements the comments from #161 (and depends on it)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn shutdown-improvements

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #172
    
----
commit 05e810fdb4377e65e72b4229b66908477be53f35
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-09-12T15:53:05Z

    Force UNIX-style line endings on shell scripts

commit 58d648a0d8acf27f91f5968f35b89366768a2968
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-09-12T16:02:55Z

    HTTP API entity helpers

commit df789d90c2ba4f0837aa36f435b3e60d8e8b416f
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-09-12T16:07:50Z

    Support for timeout parameter in the /server/shutdown request

commit 3191665ea836fbb54337485257f3a93c8fdd1b12
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-09-12T16:08:08Z

    Shutdown effector in BrooklynNode

commit 91d833891cb6c005d47d55f27f21ef995c46466a
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-09-12T16:11:52Z

    Brooklyn node safe STOP effectors
    
      * Stop but leave apps running
      * Stop apps and stop node

commit 37e966c28146f30cb11c4677c28aced4c51dbe0e
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-09-12T16:13:35Z

    Refuse stop of Brooklyn Node if there are child apps
    
    (possibly mirrored child apps added manually)

commit 79b6dd0864967c277938bf13eba95b485aff499e
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-09-15T13:20:37Z

    Support HTTP responses with empty body.

commit d6c40606a1b4e1b3285b6d9298357f19d07fc6d1
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-09-16T13:52:46Z

    Improve /server/shutdown functionality
    
      * add forceShutdownOnError - don't shutdown by default if app errors on stop
      * add shutdownTimeout - timeout shutdown waiting for apps to stop
      * add requestTimeout - timeout http request waiting for shutdown
      * add delayForHttpReturn - how long to wait before System.exit to let the request complete gracefully
      * deprecate delayMillis and make it an alias for delayForHttpReturn
    
    Update dependant effectors.

commit a309f5dc0e8f2c470e364ab385502ccb42f6d878
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-09-17T12:38:12Z

    Make the task name visible in UI

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: REST API Shutdown improvements

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/172


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: REST API Shutdown improvements

Posted by neykov <gi...@git.apache.org>.

Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/172#issuecomment-56159481
  
    Finished testing of the changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: REST API Shutdown improvements

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/172#issuecomment-56165906
  
    looks good, merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---