You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@libcloud.apache.org by "Caio Romão (Issue Comment Edited JIRA)" <ji...@apache.org> on 2011/10/02 00:20:33 UTC

[dev] [jira] [Issue Comment Edited] (LIBCLOUD-97) Create base JsonResponse and XmlResponse classes

    [ https://issues.apache.org/jira/browse/LIBCLOUD-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118910#comment-13118910 ] 

Caio Romão edited comment on LIBCLOUD-97 at 10/1/11 10:19 PM:
--------------------------------------------------------------

HI,

Is there any other functionality expected from there `JsonResponse` and `XmlResponse` classes?
I've got an experimental branch at https://github.com/caio/libcloud (response-hierarchy, tests passing for each commit) using the example pointed in the description as the base for the `JsonResponse` class.

The main problem IMO was that a lot of drivers deal differently with parse errors and empty data (mostly to work around provider oddities I believe) so the change on specialized drivers (last commit) wasn't really straightforward.

Anyway... comments?

Cheers

EDIT: Clarifying things: I've implemented the `JsonResponse` and `XmlResponse` classes in the mentioned branch and would love to hear comments about that, my interest is getting this merged :)
                
      was (Author: caioromao):
    HI,

Is there any other functionality expected from there `JsonResponse` and `XmlResponse` classes?
I've got an experimental branch at https://github.com/caio/libcloud (response-hierarchy, tests passing for each commit) using the example pointed in the description as the base for the `JsonResponse` class.

The main problem IMO is that a lot of drivers deal differently with parse errors and empty data (mostly to work around provider oddities I believe) so the change on specialized drivers (last commit) wasn't really straightforward.

Anyway... comments?

Cheers
                  
> Create base JsonResponse and XmlResponse classes
> ------------------------------------------------
>
>                 Key: LIBCLOUD-97
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-97
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute, Core
>            Reporter: Tomaz Muraus
>            Priority: Minor
>              Labels: json, response, xml
>
> https://github.com/apache/libcloud/pull/18/files#L0R15 this pattern repeats in many drivers so we should add a base `JsonResponse` and `XmlResponse` classes which drivers can use or inherit from.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira