[GitHub] [lucene-solr] madrob commented on a change in pull request #2216: SOLR-15085 Prevent EmbeddedSolrServer calling shutdown on a CoreConta…

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #2216:
URL: https://github.com/apache/lucene-solr/pull/2216#discussion_r559611053



##########
File path: solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java
##########
@@ -71,6 +71,7 @@
   protected final String coreName;
   private final SolrRequestParsers _parser;
   private final RequestWriterSupplier supplier;
+  private boolean containerIsLocal = false;

Review comment:
       Can this be final?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org