You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/30 23:34:40 UTC

[GitHub] [incubator-druid] AlexanderSaydakov commented on issue #8194: HllSketch Merge/Build BufferAggregators: Speed up init with prebuilt sketch.

AlexanderSaydakov commented on issue #8194: HllSketch Merge/Build BufferAggregators: Speed up init with prebuilt sketch.
URL: https://github.com/apache/incubator-druid/pull/8194#issuecomment-516635216
 
 
   Looks good to me.
   I would leave that comment in the init() though. Perhaps rephrase it a little. The objects are still "constructed" there by copying an empty union.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org