[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #232: feat(apisix): add timezone and extraEnvVars

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#discussion_r804462072



##########
File path: charts/apisix/values.yaml
##########
@@ -96,6 +96,16 @@ apisix:
   podAntiAffinity:
     enabled: false
 
+  # timezone is the timezone where apisix uses.
+  # For example: "UTC" or "Asia/Shanghai"
+  # This value will be set on apisix container's environment variable TZ.
+  # You may need to set the timezone to be consistent with your local time zone,
+  # otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
+  timezone: UTC
+
+  # extraEnvVars An array to add extra env vars
+  extraEnvVars: []

Review comment:
       The format for the key and value should be explained.

##########
File path: charts/apisix/values.yaml
##########
@@ -96,6 +96,16 @@ apisix:
   podAntiAffinity:
     enabled: false
 
+  # timezone is the timezone where apisix uses.
+  # For example: "UTC" or "Asia/Shanghai"
+  # This value will be set on apisix container's environment variable TZ.
+  # You may need to set the timezone to be consistent with your local time zone,
+  # otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
+  timezone: UTC

Review comment:
       Should add the documents to explain it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org