You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "maxxedev (via GitHub)" <gi...@apache.org> on 2023/04/21 09:21:52 UTC

[GitHub] [commons-io] maxxedev opened a new pull request, #452: Add ability to specify wait time to QueueInputStream

maxxedev opened a new pull request, #452:
URL: https://github.com/apache/commons-io/pull/452

   * Revert the change that adds PollingQueueInputStream and TakingQueueInputStream 
   * Add ability to specify wait time to QueueInputStream
   
   I think this will keep the API simple yet offer the roughly the same (or even more) functionality the reverted change.
   \- PollingQueueInputStream is same as `new QueueInputStream()` which has timeout=0
   \- TakingQueueInputStream is same as `new QueueInputStream(..., Duration.ofMillis(Long.MAX_VALUE))`
   
   and users can also specify arbitrary queue read timeout between 0 and LONG_MAX
   
   see also [https://github.com/apache/commons-io/pull/447 ](https://github.com/apache/commons-io/pull/447 )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] maxxedev commented on pull request #452: Add ability to specify wait time to QueueInputStream

Posted by "maxxedev (via GitHub)" <gi...@apache.org>.
maxxedev commented on PR #452:
URL: https://github.com/apache/commons-io/pull/452#issuecomment-1518937173

   Thanks for quick review and merge.
   
   Good suggestion about nanos. I did not notice that `LinkedBlockingQueue` polls using nanoseconds. Here is the PR: [https://github.com/apache/commons-io/pull/453 ](https://github.com/apache/commons-io/pull/453)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] garydgregory merged pull request #452: Add ability to specify wait time to QueueInputStream

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #452:
URL: https://github.com/apache/commons-io/pull/452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] maxxedev commented on pull request #452: Add ability to specify wait time to QueueInputStream

Posted by "maxxedev (via GitHub)" <gi...@apache.org>.
maxxedev commented on PR #452:
URL: https://github.com/apache/commons-io/pull/452#issuecomment-1518937416

   Is a changes.xml entry needed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] garydgregory commented on pull request #452: Add ability to specify wait time to QueueInputStream

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #452:
URL: https://github.com/apache/commons-io/pull/452#issuecomment-1518657241

   @maxxedev 
   TY for the PR. 
   
   I merged it and updated the code to use a builder instead of adding yet another constructor (see the rest of the code base).
   
   What feels odd is that `LinkedBlockingQueue` polls using nanoseconds and we now use milliseconds as the internal timeout, so we cannot use the most precise polling. Any thoughts on changing milliseconds to nanoseconds?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org