You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/03 16:38:27 UTC
[GitHub] [netbeans] singh-akhilesh opened a new pull request #1914:
[NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14)
singh-akhilesh opened a new pull request #1914: [NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14)
URL: https://github.com/apache/netbeans/pull/1914
https://issues.apache.org/jira/browse/NETBEANS-3786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] singh-akhilesh commented on issue #1914: [NETBEANS-3786]
: Fixed position of hint (add import) for record (jdk14).
Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on issue #1914: [NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14).
URL: https://github.com/apache/netbeans/pull/1914#issuecomment-581793313
@ebarboni Hi Erik, could you accommodate this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] singh-akhilesh commented on a change in pull request
#1914: [NETBEANS-3786] : Fixed position of hint (add import) for record
(jdk14)
Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on a change in pull request #1914: [NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14)
URL: https://github.com/apache/netbeans/pull/1914#discussion_r374470664
##########
File path: java/java.source.base/src/org/netbeans/modules/java/source/save/PositionEstimator.java
##########
@@ -314,7 +314,7 @@ public int prepare(final int startPos, StringBuilder aHead, StringBuilder aTail)
do {
Tree t = cut.getTypeDecls().get(tdpos);
typeDeclStart = (int) positions.getStartPosition(cut, t);
- if (TreeUtilities.CLASS_TREE_KINDS.contains(t.getKind())) {
+ if (TreeUtilities.CLASS_TREE_KINDS.contains(t.getKind()) || t.getKind().toString().equals(RECORD)) {
Review comment:
comment addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] arusinha commented on a change in pull request #1914:
[NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14)
Posted by GitBox <gi...@apache.org>.
arusinha commented on a change in pull request #1914: [NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14)
URL: https://github.com/apache/netbeans/pull/1914#discussion_r374220233
##########
File path: java/java.source.base/src/org/netbeans/modules/java/source/save/PositionEstimator.java
##########
@@ -314,7 +314,7 @@ public int prepare(final int startPos, StringBuilder aHead, StringBuilder aTail)
do {
Tree t = cut.getTypeDecls().get(tdpos);
typeDeclStart = (int) positions.getStartPosition(cut, t);
- if (TreeUtilities.CLASS_TREE_KINDS.contains(t.getKind())) {
+ if (TreeUtilities.CLASS_TREE_KINDS.contains(t.getKind()) || t.getKind().toString().equals(RECORD)) {
Review comment:
Please use TreeShims.RECORD
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] arusinha commented on a change in pull request #1914:
[NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14)
Posted by GitBox <gi...@apache.org>.
arusinha commented on a change in pull request #1914: [NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14)
URL: https://github.com/apache/netbeans/pull/1914#discussion_r374220042
##########
File path: java/java.source.base/src/org/netbeans/modules/java/source/save/PositionEstimator.java
##########
@@ -58,7 +58,7 @@
* For JCTree instances that have no associated source position.
*/
public static final int NOPOS = -2;
-
+ public static final String RECORD = "RECORD";
Review comment:
Please use TreeShims.RECORD
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] singh-akhilesh commented on a change in pull request
#1914: [NETBEANS-3786] : Fixed position of hint (add import) for record
(jdk14)
Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on a change in pull request #1914: [NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14)
URL: https://github.com/apache/netbeans/pull/1914#discussion_r374470630
##########
File path: java/java.source.base/src/org/netbeans/modules/java/source/save/PositionEstimator.java
##########
@@ -58,7 +58,7 @@
* For JCTree instances that have no associated source position.
*/
public static final int NOPOS = -2;
-
+ public static final String RECORD = "RECORD";
Review comment:
comment addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] singh-akhilesh commented on issue #1914: [NETBEANS-3786]
: Fixed position of hint (add import) for record (jdk14).
Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on issue #1914: [NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14).
URL: https://github.com/apache/netbeans/pull/1914#issuecomment-582365928
> hi @singh-akhilesh, would be perfect to rebase on your side. Will merge after
Rebase done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on issue #1914: [NETBEANS-3786] :
Fixed position of hint (add import) for record (jdk14).
Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #1914: [NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14).
URL: https://github.com/apache/netbeans/pull/1914#issuecomment-581824336
hi @singh-akhilesh, would be perfect to rebase on your side. Will merge after
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #1914: [NETBEANS-3786] :
Fixed position of hint (add import) for record (jdk14).
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #1914: [NETBEANS-3786] : Fixed position of hint (add import) for record (jdk14).
URL: https://github.com/apache/netbeans/pull/1914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists