[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Provide an API to modify records within files

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #351: Provide an API to modify records within files
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r310828631
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/DataOperations.java
 ##########
 @@ -44,6 +44,13 @@ private DataOperations() {
    */
   public static final String REPLACE = "replace";
 
+  /**
+   * Files are removed, replaced or modified, while changing the data in the table.
+   * <p>
+   * This operation is implemented by {@link ModifyFiles}.
+   */
+  public static final String MODIFY = "modify";
 
 Review comment:
   Files are never modified, so I think this is really an overwrite: files were added to replace files that were deleted. The set of rows in the table changed, unlike "replace" that implies the set of rows did not change. I think the two are essentially the same thing, we just need to make sure it is clear that both these uses are covered by overwrite.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org