You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by zi...@apache.org on 2025/05/03 13:20:31 UTC
(pulsar) branch master updated: [improve][build] Upgrade SpotBugs to 4.9.x (#24243)
This is an automated email from the ASF dual-hosted git repository.
zixuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 53224ecc8e1 [improve][build] Upgrade SpotBugs to 4.9.x (#24243)
53224ecc8e1 is described below
commit 53224ecc8e1e303728321d39c294af6dc10efd88
Author: Lari Hotari <lh...@users.noreply.github.com>
AuthorDate: Sat May 3 16:20:25 2025 +0300
[improve][build] Upgrade SpotBugs to 4.9.x (#24243)
---
pom.xml | 25 ++++++++++++++--------
.../pulsar/common/policies/data/TopicPolicies.java | 2 --
.../data/stats/NonPersistentTopicStatsImpl.java | 2 --
3 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/pom.xml b/pom.xml
index 47e67239b7a..a5e42cfc045 100644
--- a/pom.xml
+++ b/pom.xml
@@ -310,8 +310,8 @@ flexible messaging model and an intuitive client API.</description>
<wagon-ssh-external.version>3.5.3</wagon-ssh-external.version>
<os-maven-plugin.version>1.7.1</os-maven-plugin.version>
<jacoco-maven-plugin.version>0.8.13</jacoco-maven-plugin.version>
- <spotbugs-maven-plugin.version>4.7.3.6</spotbugs-maven-plugin.version>
- <spotbugs.version>4.7.3</spotbugs.version>
+ <spotbugs-maven-plugin.version>4.9.3.0</spotbugs-maven-plugin.version>
+ <spotbugs.version>4.9.3</spotbugs.version>
<errorprone.version>2.38.0</errorprone.version>
<errorprone-slf4j.version>0.1.28</errorprone-slf4j.version>
<j2objc-annotations.version>1.3</j2objc-annotations.version>
@@ -2272,13 +2272,20 @@ flexible messaging model and an intuitive client API.</description>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${spotbugs-maven-plugin.version}</version>
- <dependencies>
- <dependency>
- <groupId>com.github.spotbugs</groupId>
- <artifactId>spotbugs</artifactId>
- <version>${spotbugs.version}</version>
- </dependency>
- </dependencies>
+ <dependencies>
+ <dependency>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs</artifactId>
+ <version>${spotbugs.version}</version>
+ </dependency>
+ </dependencies>
+ <configuration>
+ <!--
+ TODO: remove omitted visitors and fix issues.
+ Checks have been omitted to migrate from SpotBugs 4.7.x to 4.9.x for supporting JDK 24 builds.
+ -->
+ <omitVisitors>ConstructorThrow,FindPublicAttributes,SharedVariableAtomicityDetector,UnreadFields,MultipleInstantiationsOfSingletons,InitializeNonnullFieldsInConstructor,FindNullDeref</omitVisitors>
+ </configuration>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
diff --git a/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java b/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java
index 5aa62509746..819423ce6c0 100644
--- a/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java
+++ b/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java
@@ -19,7 +19,6 @@
package org.apache.pulsar.common.policies.data;
import com.google.common.collect.Sets;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
@@ -43,7 +42,6 @@ import org.apache.pulsar.common.policies.data.impl.DispatchRateImpl;
@Builder
@NoArgsConstructor
@AllArgsConstructor
-@SuppressFBWarnings(value = "RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE")
public class TopicPolicies {
@Builder.Default
diff --git a/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/NonPersistentTopicStatsImpl.java b/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/NonPersistentTopicStatsImpl.java
index 7710c27779b..f3107f77442 100644
--- a/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/NonPersistentTopicStatsImpl.java
+++ b/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/NonPersistentTopicStatsImpl.java
@@ -117,12 +117,10 @@ public class NonPersistentTopicStatsImpl extends TopicStatsImpl implements NonPe
}
}
- @SuppressFBWarnings(value = "MF_CLASS_MASKS_FIELD", justification = "expected to override")
public Map<String, NonPersistentSubscriptionStats> getSubscriptions() {
return (Map<String, NonPersistentSubscriptionStats>) nonPersistentSubscriptions;
}
- @SuppressFBWarnings(value = "MF_CLASS_MASKS_FIELD", justification = "expected to override")
public Map<String, NonPersistentReplicatorStats> getReplication() {
return (Map<String, NonPersistentReplicatorStats>) nonPersistentReplicators;
}