[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #971: Fix/issue 964 keep password case in kvrocks2redis

[GitBox <gi...@apache.org>]

PragmaTwice commented on code in PR #971:
URL: https://github.com/apache/incubator-kvrocks/pull/971#discussion_r991258922


##########
tools/kvrocks2redis/config.cc:
##########
@@ -46,6 +46,9 @@ int Config::yesnotoi(std::string input) {
 }
 
 Status Config::parseConfigFromString(std::string input) {
+  auto oldInput = input;
+  input = Util::ToLower(input);
+  std::vector<std::string> oldArgs = Util::Split(oldInput, " \t\r\n");
   std::vector<std::string> args = Util::Split(input, " \t\r\n");
   // omit empty line and comment
   if (args.empty() || args[0].front() == '#') return Status::OK();

Review Comment:
   ```suggestion
     std::vector<std::string> args = Util::Split(input, " \t\r\n");
     // omit empty line and comment
     if (args.empty() || args[0].front() == '#') return Status::OK();
     args[0] = Util::ToLower(args[0]);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org