You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Daniel Pravat <dp...@outlook.com> on 2016/04/16 02:20:52 UTC

Review Request 46293: Windows: [3/3] Updated `sendfile` test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.


Repository: mesos


Description
-------

Windows: [3/3] Updated `sendfile` test.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 

Diff: https://reviews.apache.org/r/46293/diff/


Testing
-------

OSX: make check


Thanks,

Daniel Pravat


Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/#review130049
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On April 20, 2016, 9:48 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46293/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 9:48 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: [4/4] Updated `sendfile` test.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 
> 
> Diff: https://reviews.apache.org/r/46293/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.

Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/
-----------------------------------------------------------

(Updated April 20, 2016, 9:48 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.


Repository: mesos


Description
-------

Windows: [4/4] Updated `sendfile` test.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 

Diff: https://reviews.apache.org/r/46293/diff/


Testing
-------

OSX: make check


Thanks,

Daniel Pravat


Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/#review129784
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (lines 81 - 88)
<https://reviews.apache.org/r/46293/#comment193339>

    Sorry, from the `result.error().code` comment: by "Here and below" I also meant that we should use `result.error().message` rather than `os::strerror(_errno)`. Could you also update that please?


- Michael Park


On April 20, 2016, 4:54 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46293/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 4:54 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: [4/4] Updated `sendfile` test.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 
> 
> Diff: https://reviews.apache.org/r/46293/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.

Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/
-----------------------------------------------------------

(Updated April 20, 2016, 4:54 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.


Summary (updated)
-----------------

Windows: [4/4] Updated `sendfile` test.


Repository: mesos


Description (updated)
-------

Windows: [4/4] Updated `sendfile` test.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 

Diff: https://reviews.apache.org/r/46293/diff/


Testing
-------

OSX: make check


Thanks,

Daniel Pravat


Re: Review Request 46293: Windows: [3/3] Updated `sendfile` test.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/#review129637
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 63)
<https://reviews.apache.org/r/46293/#comment193110>

    Shouldn't this be `Try<ssize_t, SocketError>`? Here and below.



3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 65)
<https://reviews.apache.org/r/46293/#comment193108>

    Please use `ASSERT_TRUE` instead.



3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (lines 66 - 68)
<https://reviews.apache.org/r/46293/#comment193109>

    This fits in one line.



3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 83)
<https://reviews.apache.org/r/46293/#comment193111>

    We should be looking at `result.error().code`. Here and below.


- Michael Park


On April 16, 2016, 12:20 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46293/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: [3/3] Updated `sendfile` test.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 
> 
> Diff: https://reviews.apache.org/r/46293/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Re: Review Request 46293: Windows: [3/3] Updated `sendfile` test.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/#review129232
-----------------------------------------------------------



Bad patch!

Reviews applied: [46293, 46285, 43985, 46010, 46009]

Failed command: ./support/apply-review.sh -n -r 46285

Error:
2016-04-16 01:31:22 URL:https://reviews.apache.org/r/46285/diff/raw/ [2127/2127] -> "46285.patch" [1]
error: patch failed: 3rdparty/libprocess/src/poll_socket.cpp:132
error: 3rdparty/libprocess/src/poll_socket.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12557/console

- Mesos ReviewBot


On April 16, 2016, 12:20 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46293/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: [3/3] Updated `sendfile` test.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 
> 
> Diff: https://reviews.apache.org/r/46293/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>