You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dennis Lawler <dl...@gmail.com> on 2013/05/01 18:16:27 UTC
Re: Review Request: Remove filterwin2k from virtual router default config
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10843/
-----------------------------------------------------------
(Updated May 1, 2013, 4:16 p.m.)
Review request for cloudstack and Frank Zhang.
Description
-------
Commenting out filterwin2k.
Should this be pushed back as a patch for older branches as well?
This addresses bugs CLOUDSTACK-2224 and CLOUDSTACK-282.
Diffs
-----
patches/systemvm/debian/config/etc/dnsmasq.conf 7d656cb
Diff: https://reviews.apache.org/r/10843/diff/
Testing
-------
Verified in local environment that SRV records are accessible, enabling Windows KMS services.
Thanks,
Dennis Lawler
Re: Review Request: Remove filterwin2k from virtual router default config
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10843/#review20143
-----------------------------------------------------------
Ship it!
Ship It!
- Chiradeep Vittal
On May 1, 2013, 4:47 p.m., Dennis Lawler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10843/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 4:47 p.m.)
>
>
> Review request for cloudstack and Frank Zhang.
>
>
> Description
> -------
>
> Commenting out filterwin2k.
>
> Should this be pushed back as a patch for older branches as well?
>
>
> This addresses bugs CLOUDSTACK-2224 and CLOUDSTACK-282.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/etc/dnsmasq.conf 7d656cb
> patches/systemvm/debian/config/etc/vpcdnsmasq.conf 3717fc8
>
> Diff: https://reviews.apache.org/r/10843/diff/
>
>
> Testing
> -------
>
> Verified in local environment that SRV records are accessible, enabling Windows KMS services.
>
>
> Thanks,
>
> Dennis Lawler
>
>
Re: Review Request: Remove filterwin2k from virtual router default config
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10843/#review20235
-----------------------------------------------------------
Ship it!
Applied, 5e87b0a, please close
- Chiradeep Vittal
On May 3, 2013, 9:05 p.m., Dennis Lawler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10843/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 9:05 p.m.)
>
>
> Review request for cloudstack and Frank Zhang.
>
>
> Description
> -------
>
> Commenting out filterwin2k.
>
> Should this be pushed back as a patch for older branches as well?
>
>
> This addresses bugs CLOUDSTACK-2224 and CLOUDSTACK-282.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/etc/dnsmasq.conf.tmpl 7d656cb
> patches/systemvm/debian/config/etc/vpcdnsmasq.conf 3717fc8
>
> Diff: https://reviews.apache.org/r/10843/diff/
>
>
> Testing
> -------
>
> Verified in local environment that SRV records are accessible, enabling Windows KMS services.
>
>
> Thanks,
>
> Dennis Lawler
>
>
Re: Review Request: Remove filterwin2k from virtual router default config
Posted by Marcus Sorensen <sh...@gmail.com>.
Make sure you put in a request for it to be pulled into 4.1 (for
CLOUDSTACK-282), or provide a second patch if it doesn't cherry-pick
cleanly out of master!
On Fri, May 3, 2013 at 3:05 PM, Dennis Lawler <dl...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10843/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 9:05 p.m.)
>
>
> Review request for cloudstack and Frank Zhang.
>
>
> Changes
> -------
>
> Rebased patch against master!
>
>
> Description
> -------
>
> Commenting out filterwin2k.
>
> Should this be pushed back as a patch for older branches as well?
>
>
> This addresses bugs CLOUDSTACK-2224 and CLOUDSTACK-282.
>
>
> Diffs (updated)
> -----
>
> patches/systemvm/debian/config/etc/dnsmasq.conf.tmpl 7d656cb
> patches/systemvm/debian/config/etc/vpcdnsmasq.conf 3717fc8
>
> Diff: https://reviews.apache.org/r/10843/diff/
>
>
> Testing
> -------
>
> Verified in local environment that SRV records are accessible, enabling
> Windows KMS services.
>
>
> Thanks,
>
> Dennis Lawler
>
>
Re: Review Request: Remove filterwin2k from virtual router default config
Posted by Dennis Lawler <dl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10843/
-----------------------------------------------------------
(Updated May 3, 2013, 9:05 p.m.)
Review request for cloudstack and Frank Zhang.
Changes
-------
Rebased patch against master!
Description
-------
Commenting out filterwin2k.
Should this be pushed back as a patch for older branches as well?
This addresses bugs CLOUDSTACK-2224 and CLOUDSTACK-282.
Diffs (updated)
-----
patches/systemvm/debian/config/etc/dnsmasq.conf.tmpl 7d656cb
patches/systemvm/debian/config/etc/vpcdnsmasq.conf 3717fc8
Diff: https://reviews.apache.org/r/10843/diff/
Testing
-------
Verified in local environment that SRV records are accessible, enabling Windows KMS services.
Thanks,
Dennis Lawler
Re: Review Request: Remove filterwin2k from virtual router default config
Posted by Dennis Lawler <dl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10843/
-----------------------------------------------------------
(Updated May 1, 2013, 4:47 p.m.)
Review request for cloudstack and Frank Zhang.
Changes
-------
Missed vpcdnsmasq.conf in original patch.
Description
-------
Commenting out filterwin2k.
Should this be pushed back as a patch for older branches as well?
This addresses bugs CLOUDSTACK-2224 and CLOUDSTACK-282.
Diffs (updated)
-----
patches/systemvm/debian/config/etc/dnsmasq.conf 7d656cb
patches/systemvm/debian/config/etc/vpcdnsmasq.conf 3717fc8
Diff: https://reviews.apache.org/r/10843/diff/
Testing
-------
Verified in local environment that SRV records are accessible, enabling Windows KMS services.
Thanks,
Dennis Lawler