You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by Mukul Gandhi <mu...@apache.org> on 2023/01/07 17:38:42 UTC

[request to review, and vote] XalanJ 2.7.3 release candidate RC8

Hi all,
    We've published the new RC for XalanJ 2.7.3 release (located at
https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC8/). This RC,
uses Apache Commons BCEL 6.7.0, and also provides means (via improved
ant build scripts, currently updated for windows platform) to build
and test XalanJ from the source distribution.

The apache git tags corresponding to this RC, are following (these
have been committed as well),
xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc8
xalan-test repos (branch master) : xalan-j_2_7_3-rc8

The necessary XalanJ build tests pass, with this RC.

The key that can be used, to verify this RC is located within the file, at
https://dlcdn.apache.org/xalan/xalan-j/KEYS.

The XalanJ readme file, has been updated here
https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint,
describing the XalanJ build and tests process.

Kindly review and vote, for this XalanJ 2.7.3 RC.

Great work everyone. Here's my +1 for this RC.


-- 
Regards,
Mukul Gandhi

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org


Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by Mukul Gandhi <mu...@apache.org>.
Hi all,
    Within this XalanJ RC, I've mistakenly specified within
xalan-test\build.bat file something like following,

rem     Author: shane_curcuru@lotus.com,
                        ggregory@apache.org,
                        mukulg@apache.org

rem     See:    build.xml

and this causes the build script to produce an error like following,

'ggregory@apache.org' is not recognized as an internal or external command,
operable program or batch file.
'mukulg@apache.org' is not recognized as an internal or external command,
operable program or batch file.

I didn't notice this on time, and have published this XalanJ RC with
the above mentioned error. I apologize, for that.

But this error within the file xalan-test\build.bat, doesn't affect
XalanJ tests results that needs to be produced, in any way.

But I think, we should publish a new XalanJ RC, by correcting (by
mentioning batch file command 'rem' on the concerned batch file lines)
the above mentioned error.

Also, within this XalanJ RC, the concept of JARDIR environment
variable is not used while running XalanJ tests, and the mention of
that has been omitted within the readme file as well.

On Sat, Jan 7, 2023 at 11:08 PM Mukul Gandhi <mu...@apache.org> wrote:

>     We've published the new RC for XalanJ 2.7.3 release (located at
> https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC8/). This RC,
> uses Apache Commons BCEL 6.7.0, and also provides means (via improved
> ant build scripts, currently updated for windows platform) to build
> and test XalanJ from the source distribution.
>
> The apache git tags corresponding to this RC, are following (these
> have been committed as well),
> xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc8
> xalan-test repos (branch master) : xalan-j_2_7_3-rc8
>
> The necessary XalanJ build tests pass, with this RC.
>
> The key that can be used, to verify this RC is located within the file, at
> https://dlcdn.apache.org/xalan/xalan-j/KEYS.
>
> The XalanJ readme file, has been updated here
> https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint,
> describing the XalanJ build and tests process.
>
> Kindly review and vote, for this XalanJ 2.7.3 RC.
>
> Great work everyone. Here's my +1 for this RC.


-- 
Regards,
Mukul Gandhi

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org


Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by Mukul Gandhi <mu...@apache.org>.
Hi Gary,

On Sun, Jan 8, 2023 at 8:05 PM Gary Gregory <ga...@gmail.com> wrote:

> I cannot get a SHA 512 match on:
>
> shasum -a 512 xalan-j_2_7_3-src.zip.asc
> fbf3dfd1440275994efb324c1a5ce19dae3383b379d498f56136a2d91e39dbe9f93ed02d5da281c26f9f6f596bf2899c52cd7744a4966286095bdf2f2f10717e
>  xalan-j_2_7_3-src.zip.asc
>
> cat xalan-j_2_7_3-src.zip.sha512
> build\xalan-j_2_7_3-src.zip: EFBB5976 EFC81E1C 9688F5CF C2C24DAB 9B7F89FC
>                              49C7D244 6CC09339 DC7D7214 E681DD03 AE6065B8
>                              734CB6F0 231D21D0 7AC07B10 8F6F32F6 1BB0E862
>                              E0395334
>
> Also:
>
> shasum -a 512 --check xalan-j_2_7_3-src.zip.asc
> shasum: xalan-j_2_7_3-src.zip.asc: no properly formatted SHA checksum
> lines found

Lets say, we've following three files available within the XalanJ 2.7.3 RC8,

xalan-j_2_7_3-src.zip,
xalan-j_2_7_3-src.zip.sha512,
xalan-j_2_7_3-src.zip.asc

1) The contents of file xalan-j_2_7_3-src.zip.sha512 are following,

build\xalan-j_2_7_3-src.zip: EFBB5976 EFC81E1C 9688F5CF C2C24DAB 9B7F89FC
                                             49C7D244 6CC09339
DC7D7214 E681DD03 AE6065B8
                                             734CB6F0 231D21D0
7AC07B10 8F6F32F6 1BB0E862
                                             E0395334

On Windows PowerShell, when I run the command : Get-FileHash
xalan-j_2_7_3-src.zip -Algorithm SHA512

I get following result (please note the ... at the end of Hash value,
which is produced by windows),

Algorithm       Hash

                       Path
-------------       ------

                              ------
SHA512         EFBB5976EFC81E1C9688F5CFC2C24DAB9B7F89FC49C7D2446CC09339DC7D7214E68...

Therefore, I don't see any issues with the sha512 checksum that I've
published for the file xalan-j_2_7_3-src.zip.

2) xalan-j_2_7_3-src.zip.asc has the signature of file
xalan-j_2_7_3-src.zip, produced by my private key.

When I run the command gpg --verify xalan-j_2_7_3-src.zip.asc
xalan-j_2_7_3-src.zip, to verify this signature, I get following
result,

gpg: Signature made 07-01-2023 22:49:27 India Standard Time
gpg:                            using RSA key
4D8FB572FB6ADCFD69CBFE0D7B2586A6B5E25C3D
gpg: Good signature from "Mukul Gandhi (CODE SIGNING KEY)
<mu...@apache.org>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:                    There is no indication that the signature
belongs to the owner.
Primary key fingerprint: 4D8F B572 FB6A DCFD 69CB  FE0D 7B25 86A6 B5E2 5C3D

The above xalan-j_2_7_3-src.zip, file signature also looks ok to me.


-- 
Regards,
Mukul Gandhi

Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by Gary Gregory <ga...@gmail.com>.
On Sun, Jan 8, 2023 at 9:35 AM Gary Gregory <ga...@gmail.com> wrote:
>
> Hi Mukul:
>
> Thank you for preparing this RC.
>
> I cannot get a SHA 512 match on:
>
> shasum -a 512 xalan-j_2_7_3-src.zip.asc
> fbf3dfd1440275994efb324c1a5ce19dae3383b379d498f56136a2d91e39dbe9f93ed02d5da281c26f9f6f596bf2899c52cd7744a4966286095bdf2f2f10717e
>  xalan-j_2_7_3-src.zip.asc

Oops my mistake, I did not mean to take the SHA of the ASC file!

The SHA of the zip is:

shasum -a 512 xalan-j_2_7_3-src.zip
efbb5976efc81e1c9688f5cfc2c24dab9b7f89fc49c7d2446cc09339dc7d7214e681dd03ae6065b8734cb6f0231d21d07ac07b108f6f32f61bb0e862e0395334
 xalan-j_2_7_3-src.zip

Sorry about the noise!
Gary

>
> cat xalan-j_2_7_3-src.zip.sha512
> build\xalan-j_2_7_3-src.zip: EFBB5976 EFC81E1C 9688F5CF C2C24DAB 9B7F89FC
>                              49C7D244 6CC09339 DC7D7214 E681DD03 AE6065B8
>                              734CB6F0 231D21D0 7AC07B10 8F6F32F6 1BB0E862
>                              E0395334
>
> Also:
>
> shasum -a 512 --check xalan-j_2_7_3-src.zip.asc
> shasum: xalan-j_2_7_3-src.zip.asc: no properly formatted SHA checksum
> lines found
>
>
> Thoughts?
>
> Gary
>
> On Sat, Jan 7, 2023 at 12:39 PM Mukul Gandhi <mu...@apache.org> wrote:
> >
> > Hi all,
> >     We've published the new RC for XalanJ 2.7.3 release (located at
> > https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC8/). This RC,
> > uses Apache Commons BCEL 6.7.0, and also provides means (via improved
> > ant build scripts, currently updated for windows platform) to build
> > and test XalanJ from the source distribution.
> >
> > The apache git tags corresponding to this RC, are following (these
> > have been committed as well),
> > xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc8
> > xalan-test repos (branch master) : xalan-j_2_7_3-rc8
> >
> > The necessary XalanJ build tests pass, with this RC.
> >
> > The key that can be used, to verify this RC is located within the file, at
> > https://dlcdn.apache.org/xalan/xalan-j/KEYS.
> >
> > The XalanJ readme file, has been updated here
> > https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint,
> > describing the XalanJ build and tests process.
> >
> > Kindly review and vote, for this XalanJ 2.7.3 RC.
> >
> > Great work everyone. Here's my +1 for this RC.
> >
> >
> > --
> > Regards,
> > Mukul Gandhi

Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by Gary Gregory <ga...@gmail.com>.
On Sun, Jan 8, 2023 at 9:35 AM Gary Gregory <ga...@gmail.com> wrote:
>
> Hi Mukul:
>
> Thank you for preparing this RC.
>
> I cannot get a SHA 512 match on:
>
> shasum -a 512 xalan-j_2_7_3-src.zip.asc
> fbf3dfd1440275994efb324c1a5ce19dae3383b379d498f56136a2d91e39dbe9f93ed02d5da281c26f9f6f596bf2899c52cd7744a4966286095bdf2f2f10717e
>  xalan-j_2_7_3-src.zip.asc

Oops my mistake, I did not mean to take the SHA of the ASC file!

The SHA of the zip is:

shasum -a 512 xalan-j_2_7_3-src.zip
efbb5976efc81e1c9688f5cfc2c24dab9b7f89fc49c7d2446cc09339dc7d7214e681dd03ae6065b8734cb6f0231d21d07ac07b108f6f32f61bb0e862e0395334
 xalan-j_2_7_3-src.zip

Sorry about the noise!
Gary

>
> cat xalan-j_2_7_3-src.zip.sha512
> build\xalan-j_2_7_3-src.zip: EFBB5976 EFC81E1C 9688F5CF C2C24DAB 9B7F89FC
>                              49C7D244 6CC09339 DC7D7214 E681DD03 AE6065B8
>                              734CB6F0 231D21D0 7AC07B10 8F6F32F6 1BB0E862
>                              E0395334
>
> Also:
>
> shasum -a 512 --check xalan-j_2_7_3-src.zip.asc
> shasum: xalan-j_2_7_3-src.zip.asc: no properly formatted SHA checksum
> lines found
>
>
> Thoughts?
>
> Gary
>
> On Sat, Jan 7, 2023 at 12:39 PM Mukul Gandhi <mu...@apache.org> wrote:
> >
> > Hi all,
> >     We've published the new RC for XalanJ 2.7.3 release (located at
> > https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC8/). This RC,
> > uses Apache Commons BCEL 6.7.0, and also provides means (via improved
> > ant build scripts, currently updated for windows platform) to build
> > and test XalanJ from the source distribution.
> >
> > The apache git tags corresponding to this RC, are following (these
> > have been committed as well),
> > xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc8
> > xalan-test repos (branch master) : xalan-j_2_7_3-rc8
> >
> > The necessary XalanJ build tests pass, with this RC.
> >
> > The key that can be used, to verify this RC is located within the file, at
> > https://dlcdn.apache.org/xalan/xalan-j/KEYS.
> >
> > The XalanJ readme file, has been updated here
> > https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint,
> > describing the XalanJ build and tests process.
> >
> > Kindly review and vote, for this XalanJ 2.7.3 RC.
> >
> > Great work everyone. Here's my +1 for this RC.
> >
> >
> > --
> > Regards,
> > Mukul Gandhi

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org


Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by Mukul Gandhi <mu...@apache.org>.
Hi Gary,

On Sun, Jan 8, 2023 at 8:05 PM Gary Gregory <ga...@gmail.com> wrote:

> I cannot get a SHA 512 match on:
>
> shasum -a 512 xalan-j_2_7_3-src.zip.asc
> fbf3dfd1440275994efb324c1a5ce19dae3383b379d498f56136a2d91e39dbe9f93ed02d5da281c26f9f6f596bf2899c52cd7744a4966286095bdf2f2f10717e
>  xalan-j_2_7_3-src.zip.asc
>
> cat xalan-j_2_7_3-src.zip.sha512
> build\xalan-j_2_7_3-src.zip: EFBB5976 EFC81E1C 9688F5CF C2C24DAB 9B7F89FC
>                              49C7D244 6CC09339 DC7D7214 E681DD03 AE6065B8
>                              734CB6F0 231D21D0 7AC07B10 8F6F32F6 1BB0E862
>                              E0395334
>
> Also:
>
> shasum -a 512 --check xalan-j_2_7_3-src.zip.asc
> shasum: xalan-j_2_7_3-src.zip.asc: no properly formatted SHA checksum
> lines found

Lets say, we've following three files available within the XalanJ 2.7.3 RC8,

xalan-j_2_7_3-src.zip,
xalan-j_2_7_3-src.zip.sha512,
xalan-j_2_7_3-src.zip.asc

1) The contents of file xalan-j_2_7_3-src.zip.sha512 are following,

build\xalan-j_2_7_3-src.zip: EFBB5976 EFC81E1C 9688F5CF C2C24DAB 9B7F89FC
                                             49C7D244 6CC09339
DC7D7214 E681DD03 AE6065B8
                                             734CB6F0 231D21D0
7AC07B10 8F6F32F6 1BB0E862
                                             E0395334

On Windows PowerShell, when I run the command : Get-FileHash
xalan-j_2_7_3-src.zip -Algorithm SHA512

I get following result (please note the ... at the end of Hash value,
which is produced by windows),

Algorithm       Hash

                       Path
-------------       ------

                              ------
SHA512         EFBB5976EFC81E1C9688F5CFC2C24DAB9B7F89FC49C7D2446CC09339DC7D7214E68...

Therefore, I don't see any issues with the sha512 checksum that I've
published for the file xalan-j_2_7_3-src.zip.

2) xalan-j_2_7_3-src.zip.asc has the signature of file
xalan-j_2_7_3-src.zip, produced by my private key.

When I run the command gpg --verify xalan-j_2_7_3-src.zip.asc
xalan-j_2_7_3-src.zip, to verify this signature, I get following
result,

gpg: Signature made 07-01-2023 22:49:27 India Standard Time
gpg:                            using RSA key
4D8FB572FB6ADCFD69CBFE0D7B2586A6B5E25C3D
gpg: Good signature from "Mukul Gandhi (CODE SIGNING KEY)
<mu...@apache.org>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:                    There is no indication that the signature
belongs to the owner.
Primary key fingerprint: 4D8F B572 FB6A DCFD 69CB  FE0D 7B25 86A6 B5E2 5C3D

The above xalan-j_2_7_3-src.zip, file signature also looks ok to me.


-- 
Regards,
Mukul Gandhi

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org


Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by Gary Gregory <ga...@gmail.com>.
Hi Mukul:

Thank you for preparing this RC.

I cannot get a SHA 512 match on:

shasum -a 512 xalan-j_2_7_3-src.zip.asc
fbf3dfd1440275994efb324c1a5ce19dae3383b379d498f56136a2d91e39dbe9f93ed02d5da281c26f9f6f596bf2899c52cd7744a4966286095bdf2f2f10717e
 xalan-j_2_7_3-src.zip.asc

cat xalan-j_2_7_3-src.zip.sha512
build\xalan-j_2_7_3-src.zip: EFBB5976 EFC81E1C 9688F5CF C2C24DAB 9B7F89FC
                             49C7D244 6CC09339 DC7D7214 E681DD03 AE6065B8
                             734CB6F0 231D21D0 7AC07B10 8F6F32F6 1BB0E862
                             E0395334

Also:

shasum -a 512 --check xalan-j_2_7_3-src.zip.asc
shasum: xalan-j_2_7_3-src.zip.asc: no properly formatted SHA checksum
lines found


Thoughts?

Gary

On Sat, Jan 7, 2023 at 12:39 PM Mukul Gandhi <mu...@apache.org> wrote:
>
> Hi all,
>     We've published the new RC for XalanJ 2.7.3 release (located at
> https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC8/). This RC,
> uses Apache Commons BCEL 6.7.0, and also provides means (via improved
> ant build scripts, currently updated for windows platform) to build
> and test XalanJ from the source distribution.
>
> The apache git tags corresponding to this RC, are following (these
> have been committed as well),
> xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc8
> xalan-test repos (branch master) : xalan-j_2_7_3-rc8
>
> The necessary XalanJ build tests pass, with this RC.
>
> The key that can be used, to verify this RC is located within the file, at
> https://dlcdn.apache.org/xalan/xalan-j/KEYS.
>
> The XalanJ readme file, has been updated here
> https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint,
> describing the XalanJ build and tests process.
>
> Kindly review and vote, for this XalanJ 2.7.3 RC.
>
> Great work everyone. Here's my +1 for this RC.
>
>
> --
> Regards,
> Mukul Gandhi

Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by Gary Gregory <ga...@gmail.com>.
Hi Mukul:

Thank you for preparing this RC.

I cannot get a SHA 512 match on:

shasum -a 512 xalan-j_2_7_3-src.zip.asc
fbf3dfd1440275994efb324c1a5ce19dae3383b379d498f56136a2d91e39dbe9f93ed02d5da281c26f9f6f596bf2899c52cd7744a4966286095bdf2f2f10717e
 xalan-j_2_7_3-src.zip.asc

cat xalan-j_2_7_3-src.zip.sha512
build\xalan-j_2_7_3-src.zip: EFBB5976 EFC81E1C 9688F5CF C2C24DAB 9B7F89FC
                             49C7D244 6CC09339 DC7D7214 E681DD03 AE6065B8
                             734CB6F0 231D21D0 7AC07B10 8F6F32F6 1BB0E862
                             E0395334

Also:

shasum -a 512 --check xalan-j_2_7_3-src.zip.asc
shasum: xalan-j_2_7_3-src.zip.asc: no properly formatted SHA checksum
lines found


Thoughts?

Gary

On Sat, Jan 7, 2023 at 12:39 PM Mukul Gandhi <mu...@apache.org> wrote:
>
> Hi all,
>     We've published the new RC for XalanJ 2.7.3 release (located at
> https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC8/). This RC,
> uses Apache Commons BCEL 6.7.0, and also provides means (via improved
> ant build scripts, currently updated for windows platform) to build
> and test XalanJ from the source distribution.
>
> The apache git tags corresponding to this RC, are following (these
> have been committed as well),
> xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc8
> xalan-test repos (branch master) : xalan-j_2_7_3-rc8
>
> The necessary XalanJ build tests pass, with this RC.
>
> The key that can be used, to verify this RC is located within the file, at
> https://dlcdn.apache.org/xalan/xalan-j/KEYS.
>
> The XalanJ readme file, has been updated here
> https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint,
> describing the XalanJ build and tests process.
>
> Kindly review and vote, for this XalanJ 2.7.3 RC.
>
> Great work everyone. Here's my +1 for this RC.
>
>
> --
> Regards,
> Mukul Gandhi

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org


Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by Mukul Gandhi <mu...@apache.org>.
Hi all,
    Within this XalanJ RC, I've mistakenly specified within
xalan-test\build.bat file something like following,

rem     Author: shane_curcuru@lotus.com,
                        ggregory@apache.org,
                        mukulg@apache.org

rem     See:    build.xml

and this causes the build script to produce an error like following,

'ggregory@apache.org' is not recognized as an internal or external command,
operable program or batch file.
'mukulg@apache.org' is not recognized as an internal or external command,
operable program or batch file.

I didn't notice this on time, and have published this XalanJ RC with
the above mentioned error. I apologize, for that.

But this error within the file xalan-test\build.bat, doesn't affect
XalanJ tests results that needs to be produced, in any way.

But I think, we should publish a new XalanJ RC, by correcting (by
mentioning batch file command 'rem' on the concerned batch file lines)
the above mentioned error.

Also, within this XalanJ RC, the concept of JARDIR environment
variable is not used while running XalanJ tests, and the mention of
that has been omitted within the readme file as well.

On Sat, Jan 7, 2023 at 11:08 PM Mukul Gandhi <mu...@apache.org> wrote:

>     We've published the new RC for XalanJ 2.7.3 release (located at
> https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC8/). This RC,
> uses Apache Commons BCEL 6.7.0, and also provides means (via improved
> ant build scripts, currently updated for windows platform) to build
> and test XalanJ from the source distribution.
>
> The apache git tags corresponding to this RC, are following (these
> have been committed as well),
> xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc8
> xalan-test repos (branch master) : xalan-j_2_7_3-rc8
>
> The necessary XalanJ build tests pass, with this RC.
>
> The key that can be used, to verify this RC is located within the file, at
> https://dlcdn.apache.org/xalan/xalan-j/KEYS.
>
> The XalanJ readme file, has been updated here
> https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint,
> describing the XalanJ build and tests process.
>
> Kindly review and vote, for this XalanJ 2.7.3 RC.
>
> Great work everyone. Here's my +1 for this RC.


-- 
Regards,
Mukul Gandhi

Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by Gary Gregory <ga...@gmail.com>.
I just tested RC9 and it was ok, I'll reply there.

Gary

On Mon, Jan 9, 2023, 10:38 Mukul Gandhi <mu...@apache.org> wrote:

> Hi Gary,
>
> On Sun, Jan 8, 2023 at 10:26 PM Gary D. Gregory <gg...@apache.org>
> wrote:
> >
> > So I am a little worried that we are testing the latest from master but
> maybe that's ok, you tell me
>
> This is ok I believe, as we've been discussing and have agreed upon
> earlier on XalanJ lists.
>
> We've published the XalanJ 2.7.3 RC9 sometime ago today, and an email
> was sent to XalanJ lists mentioning that. The changes within XalanJ
> 2.7.3 RC9 are mentioned within RC9 email. The main XalanJ RC9 change
> was within build.bat file as suggested by you during review of XalanJ
> RC8, and minor change to readme file.
>
>
> --
> Regards,
> Mukul Gandhi
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
> For additional commands, e-mail: dev-help@xalan.apache.org
>
>

Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by Mukul Gandhi <mu...@apache.org>.
Hi Gary,

On Sun, Jan 8, 2023 at 10:26 PM Gary D. Gregory <gg...@apache.org> wrote:
>
> So I am a little worried that we are testing the latest from master but maybe that's ok, you tell me

This is ok I believe, as we've been discussing and have agreed upon
earlier on XalanJ lists.

We've published the XalanJ 2.7.3 RC9 sometime ago today, and an email
was sent to XalanJ lists mentioning that. The changes within XalanJ
2.7.3 RC9 are mentioned within RC9 email. The main XalanJ RC9 change
was within build.bat file as suggested by you during review of XalanJ
RC8, and minor change to readme file.


-- 
Regards,
Mukul Gandhi

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org


Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by "Gary D. Gregory" <gg...@apache.org>.
So I am a little worried that we are testing the latest from master but maybe that's ok, you tell me. Aside from that and the notes below I was able to run through the rest of the readme file and all of the build commands on Windows, yes, all the way to xsltc_int_truncation_test.bat :-)

So +1

My test env:

Apache Ant(TM) version 1.10.12 compiled on October 13 2021

openjdk version "1.8.0_352"
OpenJDK Runtime Environment (Temurin)(build 1.8.0_352-b08)
OpenJDK 64-Bit Server VM (Temurin)(build 25.352-b08, mixed mode)

Microsoft Windows [Version 10.0.19044.2364]

I tried and gave up on macOS as I did not want to debug or adapt the build sh file.

Gary

On 2023/01/08 16:49:15 "Gary D. Gregory" wrote:
> I don't understand why the fix below was needed because it so in git master.
> 
> Gary
> 
> On 2023/01/08 16:48:19 "Gary D. Gregory" wrote:
> > Required edit to build.bat:
> > 
> > "%_JAVACMD%" -mx1024m -classpath %_CLASSPATH% org.apache.tools.ant.Main %1 %2 %3 %4 %5 %6 %7 %8 %9
> > 
> > ->
> > 
> > "%_JAVACMD%" -mx1024m -classpath "%_CLASSPATH%" org.apache.tools.ant.Main %1 %2 %3 %4 %5 %6 %7 %8 %9
> > 
> > Note the double quotes around %_CLASSPATH% which is required when your Java install folder contains spaces, for example: C:\Program Files\Eclipse Adoptium\jdk-8.0.352.8-hotspot\
> > 
> > Gary
> > 
> > On 2023/01/07 17:38:42 Mukul Gandhi wrote:
> > > Hi all,
> > >     We've published the new RC for XalanJ 2.7.3 release (located at
> > > https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC8/). This RC,
> > > uses Apache Commons BCEL 6.7.0, and also provides means (via improved
> > > ant build scripts, currently updated for windows platform) to build
> > > and test XalanJ from the source distribution.
> > > 
> > > The apache git tags corresponding to this RC, are following (these
> > > have been committed as well),
> > > xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc8
> > > xalan-test repos (branch master) : xalan-j_2_7_3-rc8
> > > 
> > > The necessary XalanJ build tests pass, with this RC.
> > > 
> > > The key that can be used, to verify this RC is located within the file, at
> > > https://dlcdn.apache.org/xalan/xalan-j/KEYS.
> > > 
> > > The XalanJ readme file, has been updated here
> > > https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint,
> > > describing the XalanJ build and tests process.
> > > 
> > > Kindly review and vote, for this XalanJ 2.7.3 RC.
> > > 
> > > Great work everyone. Here's my +1 for this RC.
> > > 
> > > 
> > > -- 
> > > Regards,
> > > Mukul Gandhi
> > > 
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
> > > For additional commands, e-mail: dev-help@xalan.apache.org
> > > 
> > > 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
> > For additional commands, e-mail: dev-help@xalan.apache.org
> > 
> > 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
> For additional commands, e-mail: dev-help@xalan.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org


Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by "Gary D. Gregory" <gg...@apache.org>.
I don't understand why the fix below was needed because it so in git master.

Gary

On 2023/01/08 16:48:19 "Gary D. Gregory" wrote:
> Required edit to build.bat:
> 
> "%_JAVACMD%" -mx1024m -classpath %_CLASSPATH% org.apache.tools.ant.Main %1 %2 %3 %4 %5 %6 %7 %8 %9
> 
> ->
> 
> "%_JAVACMD%" -mx1024m -classpath "%_CLASSPATH%" org.apache.tools.ant.Main %1 %2 %3 %4 %5 %6 %7 %8 %9
> 
> Note the double quotes around %_CLASSPATH% which is required when your Java install folder contains spaces, for example: C:\Program Files\Eclipse Adoptium\jdk-8.0.352.8-hotspot\
> 
> Gary
> 
> On 2023/01/07 17:38:42 Mukul Gandhi wrote:
> > Hi all,
> >     We've published the new RC for XalanJ 2.7.3 release (located at
> > https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC8/). This RC,
> > uses Apache Commons BCEL 6.7.0, and also provides means (via improved
> > ant build scripts, currently updated for windows platform) to build
> > and test XalanJ from the source distribution.
> > 
> > The apache git tags corresponding to this RC, are following (these
> > have been committed as well),
> > xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc8
> > xalan-test repos (branch master) : xalan-j_2_7_3-rc8
> > 
> > The necessary XalanJ build tests pass, with this RC.
> > 
> > The key that can be used, to verify this RC is located within the file, at
> > https://dlcdn.apache.org/xalan/xalan-j/KEYS.
> > 
> > The XalanJ readme file, has been updated here
> > https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint,
> > describing the XalanJ build and tests process.
> > 
> > Kindly review and vote, for this XalanJ 2.7.3 RC.
> > 
> > Great work everyone. Here's my +1 for this RC.
> > 
> > 
> > -- 
> > Regards,
> > Mukul Gandhi
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
> > For additional commands, e-mail: dev-help@xalan.apache.org
> > 
> > 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
> For additional commands, e-mail: dev-help@xalan.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org


Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC8

Posted by "Gary D. Gregory" <gg...@apache.org>.
Required edit to build.bat:

"%_JAVACMD%" -mx1024m -classpath %_CLASSPATH% org.apache.tools.ant.Main %1 %2 %3 %4 %5 %6 %7 %8 %9

->

"%_JAVACMD%" -mx1024m -classpath "%_CLASSPATH%" org.apache.tools.ant.Main %1 %2 %3 %4 %5 %6 %7 %8 %9

Note the double quotes around %_CLASSPATH% which is required when your Java install folder contains spaces, for example: C:\Program Files\Eclipse Adoptium\jdk-8.0.352.8-hotspot\

Gary

On 2023/01/07 17:38:42 Mukul Gandhi wrote:
> Hi all,
>     We've published the new RC for XalanJ 2.7.3 release (located at
> https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC8/). This RC,
> uses Apache Commons BCEL 6.7.0, and also provides means (via improved
> ant build scripts, currently updated for windows platform) to build
> and test XalanJ from the source distribution.
> 
> The apache git tags corresponding to this RC, are following (these
> have been committed as well),
> xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc8
> xalan-test repos (branch master) : xalan-j_2_7_3-rc8
> 
> The necessary XalanJ build tests pass, with this RC.
> 
> The key that can be used, to verify this RC is located within the file, at
> https://dlcdn.apache.org/xalan/xalan-j/KEYS.
> 
> The XalanJ readme file, has been updated here
> https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint,
> describing the XalanJ build and tests process.
> 
> Kindly review and vote, for this XalanJ 2.7.3 RC.
> 
> Great work everyone. Here's my +1 for this RC.
> 
> 
> -- 
> Regards,
> Mukul Gandhi
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
> For additional commands, e-mail: dev-help@xalan.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org