[jira] [Commented] (NIFI-1099) Interrupted status is not restored

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992193#comment-14992193 ] 

ASF GitHub Bot commented on NIFI-1099:
--------------------------------------

GitHub user olegz opened a pull request:

    https://github.com/apache/nifi/pull/115

    NIFI-1099 fixed the handling of InterruptedException

    In many places current code simply swallows InterruptedException without allowing
    calling thread to be notified  of the interrupt. We should not be doing this as it could lead to
    various side-effects (e.g., Thread pool waiting for completion of the interrupted task, a completion that).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/olegz/nifi NIFI-1099

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit a15b44485f4f062f0bfae5bed70c9566b5932649
Author: Oleg Zhurakousky <ol...@suitcase.io>
Date:   2015-11-05T18:29:13Z

    NIFI-1099 dixed the handling of InterruptedException
    In many places current code simply swallows InterruptedException without allowing
    calling thread to be notified  of the interrupt. We should not be doing this as it could lead to
    various side-effects (e.g., Thread pool waiting for completion of the interrupted task, a completion that).

----


> Interrupted status is not restored
> ----------------------------------
>
>                 Key: NIFI-1099
>                 URL: https://issues.apache.org/jira/browse/NIFI-1099
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>             Fix For: 0.4.0
>
>
> There are few places with code that looks like this
> {code}
> try {
>    Thread.sleep(val);
> } catch (InterruptedException ie) {
> }
> {code}
> . . . and the interrupted status of the thread is not restored. Need at the very least 
> {code}
> Thread.currentThread().interrupt();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)