You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/14 08:53:37 UTC
[GitHub] [tvm] Alexey-Yazev opened a new pull request, #13365: [microNPU] Fix Cascader code generation without StorageRewrite
Alexey-Yazev opened a new pull request, #13365:
URL: https://github.com/apache/tvm/pull/13365
This PR fixes Cascader code generation without StorageRewrite (when striping is enabled) on Ethos-U NPU.
The problem was that after the Replace Operator's pass, the buffers for partial results of the operation were replaced with a buffer with the results of the entire operation and it was indicated that the buffer needed to be allocated, summing up we received a larger size in the number of parts.
Due to a problem with the hill_climb algorithm, I had to increase the workspace_size for the test case test_networks_with_usmp_and_cascader_with_striping. For the test case test_networks_with_usmp_and_cascader_with_striping allocated_size is 803264 but the algorithm requires 1204224 this happens due to the reuse of the buffer, but the algorithm does not take this into account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda commented on pull request #13365: [microNPU] Fix Cascader code generation without StorageRewrite
Posted by GitBox <gi...@apache.org>.
ekalda commented on PR #13365:
URL: https://github.com/apache/tvm/pull/13365#issuecomment-1320281976
Thanks @Alexey-Yazev!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Alexey-Yazev commented on pull request #13365: [microNPU] Fix Cascader code generation without StorageRewrite
Posted by GitBox <gi...@apache.org>.
Alexey-Yazev commented on PR #13365:
URL: https://github.com/apache/tvm/pull/13365#issuecomment-1313312029
cc @leandron @ekalda, @NicolaLancellotti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13365: [microNPU] Fix Cascader code generation without StorageRewrite
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13365:
URL: https://github.com/apache/tvm/pull/13365#issuecomment-1313306304
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Mousius, @lhutton1 <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda merged pull request #13365: [microNPU] Fix Cascader code generation without StorageRewrite
Posted by GitBox <gi...@apache.org>.
ekalda merged PR #13365:
URL: https://github.com/apache/tvm/pull/13365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Alexey-Yazev commented on pull request #13365: [microNPU] Fix Cascader code generation without StorageRewrite
Posted by GitBox <gi...@apache.org>.
Alexey-Yazev commented on PR #13365:
URL: https://github.com/apache/tvm/pull/13365#issuecomment-1316823243
> Looks great, thanks for tracking this down! I suppose we want to wait for #13369 before merging?
Yes, with these changes, the test will not be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org