You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/12/28 11:41:27 UTC
[GitHub] [incubator-mxnet] dibgerge opened a new pull request #19721: [BUGFIX] Fixed problem with Distribution repr due to cached_property
dibgerge opened a new pull request #19721:
URL: https://github.com/apache/incubator-mxnet/pull/19721
## Description ##
The `repr` of Distribution base class fails when any of its subclasses has one of its `arg_constraints` defined as `cached_property` which has not yet been initialized. This affects only Mxnet 2.
Solves #19720
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [x ] Code is well-documented
### Changes ###
- Uninitialized `cached_properties` will appear with size `None`. For example a `Categorical` distribution initialized with logit values, will show `prob` size as `None` untill `prob` is called.
```
Categorical(prob: size None, logit: size (3,), F: mxnet.ndarray, event_dim: 0)
```
## Comments ##
- Another possible solution which doesn't need lots of code change is calling the uncached property within the `__repr__` method, which will force initialize it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] dibgerge commented on pull request #19721: [BUGFIX] Fixed problem with Distribution repr due to cached_property
Posted by GitBox <gi...@apache.org>.
dibgerge commented on pull request #19721:
URL: https://github.com/apache/incubator-mxnet/pull/19721#issuecomment-752743149
@xidulu Added a comment in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19721: [BUGFIX] Fixed problem with Distribution repr due to cached_property
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19721:
URL: https://github.com/apache/incubator-mxnet/pull/19721#issuecomment-753295206
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] xidulu merged pull request #19721: [BUGFIX] Fixed problem with Distribution repr due to cached_property
Posted by GitBox <gi...@apache.org>.
xidulu merged pull request #19721:
URL: https://github.com/apache/incubator-mxnet/pull/19721
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19721: [BUGFIX] Fixed problem with Distribution repr due to cached_property
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19721:
URL: https://github.com/apache/incubator-mxnet/pull/19721#issuecomment-751684449
Hey @dibgerge , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, windows-gpu, unix-cpu, miscellaneous, centos-cpu, sanity, unix-gpu, windows-cpu, centos-gpu, edge, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] xidulu commented on pull request #19721: [BUGFIX] Fixed problem with Distribution repr due to cached_property
Posted by GitBox <gi...@apache.org>.
xidulu commented on pull request #19721:
URL: https://github.com/apache/incubator-mxnet/pull/19721#issuecomment-753295198
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org