[GitHub] [ozone] adoroszlai commented on pull request #2048: HDDS-4984. Support async profiler 2.0

[GitBox <gi...@apache.org>]

adoroszlai commented on pull request #2048:
URL: https://github.com/apache/ozone/pull/2048#issuecomment-800987184


   > > 2.0 works with -o svg, although profiler's help does not mention it as a valid output format.
   > is it? i think it threw an error at me when i specified svg output...
   
   I think I was fooled by some docker-specific behavior (tried to replace `/opt/profiler` at runtime...).
   
   Now with proper 2.0 installation I see the problem with `-o svg`.
   
   It might be improved by checking the subprocess for error result instead of waiting forever for the output file.
   
   > how about adding another system property to specify the async profiler version, and defaults to flamegraph if it's 2.0?
   
   We could also run the profiler with `-v` first to get the version number.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org