You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Kevin Risden (JIRA)" <ji...@apache.org> on 2018/11/07 21:43:00 UTC

[jira] [Comment Edited] (CALCITE-2660) OsAdapterTest should check if required commands are available

    [ https://issues.apache.org/jira/browse/CALCITE-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678816#comment-16678816 ] 

Kevin Risden edited comment on CALCITE-2660 at 11/7/18 9:42 PM:
----------------------------------------------------------------

For reference the failures from [https://travis-ci.org/apache/calcite/jobs/452098457:]
{code:java}
[INFO] Running org.apache.calcite.adapter.os.OsAdapterTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[ERROR] Tests run: 12, Failures: 1, Errors: 4, Skipped: 0, Time elapsed: 5.697 s <<< FAILURE! - in org.apache.calcite.adapter.os.OsAdapterTest
[ERROR] testGitCommits(org.apache.calcite.adapter.os.OsAdapterTest)  Time elapsed: 2.617 s  <<< ERROR!
java.lang.RuntimeException: exception while executing [select count(*) from git_commits]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)
Caused by: java.lang.RuntimeException: With materializationsEnabled=false, limit=0
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)
Caused by: java.sql.SQLException: Error while executing SQL "select count(*) from git_commits": while creating process: [git, log, --pretty=raw]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)
Caused by: java.lang.RuntimeException: while creating process: [git, log, --pretty=raw]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)
Caused by: java.io.IOException: Cannot run program "git": error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)
Caused by: java.io.IOException: error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)

[ERROR] testGitCommitsTop(org.apache.calcite.adapter.os.OsAdapterTest)  Time elapsed: 0.481 s  <<< ERROR!
java.lang.RuntimeException: 
exception while executing [select author from git_commits
group by 1 order by count(*) desc limit 2]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)
Caused by: java.lang.RuntimeException: With materializationsEnabled=false, limit=0
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)
Caused by: java.sql.SQLException: 
Error while executing SQL "select author from git_commits
group by 1 order by count(*) desc limit 2": while creating process: [git, log, --pretty=raw]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)
Caused by: java.lang.RuntimeException: while creating process: [git, log, --pretty=raw]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)
Caused by: java.io.IOException: Cannot run program "git": error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)
Caused by: java.io.IOException: error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)

[ERROR] testPs(org.apache.calcite.adapter.os.OsAdapterTest)  Time elapsed: 0.305 s  <<< ERROR!
java.lang.RuntimeException: exception while executing [select * from ps]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)
Caused by: java.lang.RuntimeException: With materializationsEnabled=false, limit=0
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)
Caused by: java.sql.SQLException: Error while executing SQL "select * from ps": while creating process: [ps, --no-headers, axo, ppid,pid,pgrp,tpgid,stat,user,pcpu,pmem,vsz,rss,tty,start_time,time,euid,ruid,sess,comm]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)
Caused by: java.lang.RuntimeException: while creating process: [ps, --no-headers, axo, ppid,pid,pgrp,tpgid,stat,user,pcpu,pmem,vsz,rss,tty,start_time,time,euid,ruid,sess,comm]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)
Caused by: java.io.IOException: Cannot run program "ps": error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)
Caused by: java.io.IOException: error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)

[ERROR] testPsDistinct(org.apache.calcite.adapter.os.OsAdapterTest)  Time elapsed: 0.061 s  <<< ERROR!
java.lang.RuntimeException: exception while executing [select distinct `user` from ps]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)
Caused by: java.lang.RuntimeException: With materializationsEnabled=false, limit=0
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)
Caused by: java.sql.SQLException: Error while executing SQL "select distinct `user` from ps": while creating process: [ps, --no-headers, axo, ppid,pid,pgrp,tpgid,stat,user,pcpu,pmem,vsz,rss,tty,start_time,time,euid,ruid,sess,comm]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)
Caused by: java.lang.RuntimeException: while creating process: [ps, --no-headers, axo, ppid,pid,pgrp,tpgid,stat,user,pcpu,pmem,vsz,rss,tty,start_time,time,euid,ruid,sess,comm]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)
Caused by: java.io.IOException: Cannot run program "ps": error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)
Caused by: java.io.IOException: error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)

[ERROR] testVmstat(org.apache.calcite.adapter.os.OsAdapterTest)  Time elapsed: 0.164 s  <<< FAILURE!
java.lang.AssertionError: 

Expected: is <true>
     but: was <false>
	at org.apache.calcite.adapter.os.OsAdapterTest.lambda$testVmstat$6(OsAdapterTest.java:192)
	at org.apache.calcite.adapter.os.OsAdapterTest.testVmstat(OsAdapterTest.java:190)

[INFO] Running org.apache.calcite.chinook.EndToEndTest
Nov 07, 2018 5:17:20 PM org.hsqldb.persist.Logger logInfoEvent
INFO: open start - state modified
Nov 07, 2018 5:17:21 PM org.hsqldb.persist.Logger logInfoEvent
INFO: Checkpoint start
Nov 07, 2018 5:17:21 PM org.hsqldb.persist.Logger logInfoEvent
INFO: Checkpoint end - txts: 54
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.683 s - in org.apache.calcite.chinook.EndToEndTest
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   OsAdapterTest.testVmstat:190->lambda$testVmstat$6:192 
Expected: is <true>
     but: was <false>
[ERROR] Errors: 
[ERROR]   OsAdapterTest.testGitCommits:167 ? Runtime exception while executing [select c...
[ERROR]   OsAdapterTest.testGitCommitsTop:182 ? Runtime exception while executing [selec...
[ERROR]   OsAdapterTest.testPs:133 ? Runtime exception while executing [select * from ps...
[ERROR]   OsAdapterTest.testPsDistinct:153 ? Runtime exception while executing [select d...
[INFO] 
[ERROR] Tests run: 56, Failures: 1, Errors: 4, Skipped: 21{code}


was (Author: risdenk):
For reference the failures from https://travis-ci.org/apache/calcite/jobs/452098457:
{code:java}
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.calcite.adapter.tpcds.TpcdsTest
LogicalSort(sort0=[$1], sort1=[$0], dir0=[ASC], dir1=[ASC], fetch=[100])
  LogicalAggregate(group=[{84, 90}], AGG1=[AVG($10)], AGG2=[AVG($12)], AGG3=[AVG($19)], AGG4=[AVG($13)])
    LogicalFilter(condition=[AND(=($0, $32), =($2, $89), =($7, $60), =($4, $23), =($24, 'M'), =($25, 'S'), =($26, 'HIGH SCHOOL'), =($38, 1998), IN($84, ARRAY('CA', 'OR', 'WA', 'TX', 'OK', 'MD')))])
      LogicalJoin(condition=[true], joinType=[inner])
        LogicalTableScan(table=[[TPCDS, STORE_SALES]])
        LogicalJoin(condition=[true], joinType=[inner])
          LogicalTableScan(table=[[TPCDS, CUSTOMER_DEMOGRAPHICS]])
          LogicalJoin(condition=[true], joinType=[inner])
            LogicalTableScan(table=[[TPCDS, DATE_DIM]])
            LogicalJoin(condition=[true], joinType=[inner])
              LogicalTableScan(table=[[TPCDS, STORE]])
              LogicalTableScan(table=[[TPCDS, ITEM]])

[WARNING] Tests run: 11, Failures: 0, Errors: 0, Skipped: 7, Time elapsed: 0.3 s - in org.apache.calcite.adapter.tpcds.TpcdsTest
[INFO] Running org.apache.calcite.adapter.tpch.TpchTest
[WARNING] Tests run: 29, Failures: 0, Errors: 0, Skipped: 14, Time elapsed: 0.016 s - in org.apache.calcite.adapter.tpch.TpchTest
[INFO] Running org.apache.calcite.adapter.os.OsAdapterTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[ERROR] Tests run: 12, Failures: 1, Errors: 4, Skipped: 0, Time elapsed: 5.697 s <<< FAILURE! - in org.apache.calcite.adapter.os.OsAdapterTest
[ERROR] testGitCommits(org.apache.calcite.adapter.os.OsAdapterTest)  Time elapsed: 2.617 s  <<< ERROR!
java.lang.RuntimeException: exception while executing [select count(*) from git_commits]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)
Caused by: java.lang.RuntimeException: With materializationsEnabled=false, limit=0
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)
Caused by: java.sql.SQLException: Error while executing SQL "select count(*) from git_commits": while creating process: [git, log, --pretty=raw]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)
Caused by: java.lang.RuntimeException: while creating process: [git, log, --pretty=raw]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)
Caused by: java.io.IOException: Cannot run program "git": error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)
Caused by: java.io.IOException: error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommits(OsAdapterTest.java:167)

[ERROR] testGitCommitsTop(org.apache.calcite.adapter.os.OsAdapterTest)  Time elapsed: 0.481 s  <<< ERROR!
java.lang.RuntimeException: 
exception while executing [select author from git_commits
group by 1 order by count(*) desc limit 2]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)
Caused by: java.lang.RuntimeException: With materializationsEnabled=false, limit=0
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)
Caused by: java.sql.SQLException: 
Error while executing SQL "select author from git_commits
group by 1 order by count(*) desc limit 2": while creating process: [git, log, --pretty=raw]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)
Caused by: java.lang.RuntimeException: while creating process: [git, log, --pretty=raw]
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)
Caused by: java.io.IOException: Cannot run program "git": error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)
Caused by: java.io.IOException: error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testGitCommitsTop(OsAdapterTest.java:182)

[ERROR] testPs(org.apache.calcite.adapter.os.OsAdapterTest)  Time elapsed: 0.305 s  <<< ERROR!
java.lang.RuntimeException: exception while executing [select * from ps]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)
Caused by: java.lang.RuntimeException: With materializationsEnabled=false, limit=0
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)
Caused by: java.sql.SQLException: Error while executing SQL "select * from ps": while creating process: [ps, --no-headers, axo, ppid,pid,pgrp,tpgid,stat,user,pcpu,pmem,vsz,rss,tty,start_time,time,euid,ruid,sess,comm]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)
Caused by: java.lang.RuntimeException: while creating process: [ps, --no-headers, axo, ppid,pid,pgrp,tpgid,stat,user,pcpu,pmem,vsz,rss,tty,start_time,time,euid,ruid,sess,comm]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)
Caused by: java.io.IOException: Cannot run program "ps": error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)
Caused by: java.io.IOException: error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testPs(OsAdapterTest.java:133)

[ERROR] testPsDistinct(org.apache.calcite.adapter.os.OsAdapterTest)  Time elapsed: 0.061 s  <<< ERROR!
java.lang.RuntimeException: exception while executing [select distinct `user` from ps]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)
Caused by: java.lang.RuntimeException: With materializationsEnabled=false, limit=0
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)
Caused by: java.sql.SQLException: Error while executing SQL "select distinct `user` from ps": while creating process: [ps, --no-headers, axo, ppid,pid,pgrp,tpgid,stat,user,pcpu,pmem,vsz,rss,tty,start_time,time,euid,ruid,sess,comm]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)
Caused by: java.lang.RuntimeException: while creating process: [ps, --no-headers, axo, ppid,pid,pgrp,tpgid,stat,user,pcpu,pmem,vsz,rss,tty,start_time,time,euid,ruid,sess,comm]
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)
Caused by: java.io.IOException: Cannot run program "ps": error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)
Caused by: java.io.IOException: error=2, No such file or directory
	at org.apache.calcite.adapter.os.OsAdapterTest.testPsDistinct(OsAdapterTest.java:153)

[ERROR] testVmstat(org.apache.calcite.adapter.os.OsAdapterTest)  Time elapsed: 0.164 s  <<< FAILURE!
java.lang.AssertionError: 

Expected: is <true>
     but: was <false>
	at org.apache.calcite.adapter.os.OsAdapterTest.lambda$testVmstat$6(OsAdapterTest.java:192)
	at org.apache.calcite.adapter.os.OsAdapterTest.testVmstat(OsAdapterTest.java:190)

[INFO] Running org.apache.calcite.chinook.EndToEndTest
Nov 07, 2018 5:17:20 PM org.hsqldb.persist.Logger logInfoEvent
INFO: open start - state modified
Nov 07, 2018 5:17:21 PM org.hsqldb.persist.Logger logInfoEvent
INFO: Checkpoint start
Nov 07, 2018 5:17:21 PM org.hsqldb.persist.Logger logInfoEvent
INFO: Checkpoint end - txts: 54
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.683 s - in org.apache.calcite.chinook.EndToEndTest
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   OsAdapterTest.testVmstat:190->lambda$testVmstat$6:192 
Expected: is <true>
     but: was <false>
[ERROR] Errors: 
[ERROR]   OsAdapterTest.testGitCommits:167 ? Runtime exception while executing [select c...
[ERROR]   OsAdapterTest.testGitCommitsTop:182 ? Runtime exception while executing [selec...
[ERROR]   OsAdapterTest.testPs:133 ? Runtime exception while executing [select * from ps...
[ERROR]   OsAdapterTest.testPsDistinct:153 ? Runtime exception while executing [select d...
[INFO] 
[ERROR] Tests run: 56, Failures: 1, Errors: 4, Skipped: 21{code}

> OsAdapterTest should check if required commands are available
> -------------------------------------------------------------
>
>                 Key: CALCITE-2660
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2660
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Kevin Risden
>            Assignee: Julian Hyde
>            Priority: Minor
>             Fix For: 1.18.0
>
>
> Found via CALCITE-2655, OsAdapterTest assumes that ps and git are installed. This should be checked. Once OsAdapterTest is fixed, allow_failures should be removed from .travis.yml for jdk 12.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)