You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/25 12:05:10 UTC
[GitHub] [spark] gengliangwang commented on a change in pull request #35972: [SPARK-38656][UI][PYTHON] Show options for Pandas API on Spark in UI
gengliangwang commented on a change in pull request #35972:
URL: https://github.com/apache/spark/pull/35972#discussion_r835209118
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/ExecutionPage.scala
##########
@@ -148,6 +155,8 @@ class ExecutionPage(parent: SQLTab) extends WebUIPage("execution") with Logging
}
private def modifiedConfigs(modifiedConfigs: Map[String, String]): Seq[Node] = {
+ if (Option(modifiedConfigs).exists(_.isEmpty)) return Nil
Review comment:
Why not just
```
if (modifiedConfigs.isEmpty) ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org