You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/09/18 07:54:45 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #42975: [SPARK-45197][CORE] Make StandaloneRestServer add JavaModuleOptions to drivers
dongjoon-hyun opened a new pull request, #42975:
URL: https://github.com/apache/spark/pull/42975
### What changes were proposed in this pull request?
This PR aims to make `StandaloneRestServer` add `JavaModuleOptions` to drivers by default.
### Why are the changes needed?
Since Apache Spark 3.3.0 (SPARK-36796, #34153), `SparkContext` adds `JavaModuleOptions` by default.
We had better add `JavaModuleOptions` when `StandaloneRestServer` receives submissions via REST API, too.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42975: [SPARK-45197][CORE] Make `StandaloneRestServer` add `JavaModuleOptions` to drivers
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42975:
URL: https://github.com/apache/spark/pull/42975#issuecomment-1723004865
Thank you always, @yaooqinn and @LuciferYang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42975: [SPARK-45197][CORE] Make `StandaloneRestServer` add `JavaModuleOptions` to drivers
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42975:
URL: https://github.com/apache/spark/pull/42975#discussion_r1328362116
##########
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala:
##########
@@ -124,7 +124,10 @@ private[rest] class StandaloneSubmitRequestServlet(
* fields used by python applications since python is not supported in standalone
* cluster mode yet.
*/
- private def buildDriverDescription(request: CreateSubmissionRequest): DriverDescription = {
+ private[rest] def buildDriverDescription(
+ request: CreateSubmissionRequest,
+ masterUrl: String,
+ masterRestPort: Int): DriverDescription = {
Review Comment:
This private method is revised for better testing by using dependency injection pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42975: [SPARK-45197][CORE] Make `StandaloneRestServer` add `JavaModuleOptions` to drivers
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42975: [SPARK-45197][CORE] Make `StandaloneRestServer` add `JavaModuleOptions` to drivers
URL: https://github.com/apache/spark/pull/42975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42975: [SPARK-45197][CORE] Make `StandaloneRestServer` add `JavaModuleOptions` to drivers
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42975:
URL: https://github.com/apache/spark/pull/42975#issuecomment-1723196060
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42975: [SPARK-45197][CORE] Make `StandaloneRestServer` add `JavaModuleOptions` to drivers
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42975:
URL: https://github.com/apache/spark/pull/42975#discussion_r1328362116
##########
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala:
##########
@@ -124,7 +124,10 @@ private[rest] class StandaloneSubmitRequestServlet(
* fields used by python applications since python is not supported in standalone
* cluster mode yet.
*/
- private def buildDriverDescription(request: CreateSubmissionRequest): DriverDescription = {
+ private[rest] def buildDriverDescription(
+ request: CreateSubmissionRequest,
+ masterUrl: String,
+ masterRestPort: Int): DriverDescription = {
Review Comment:
This private method arguments are revised for better testing by taking advantage of dependency injection pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org