You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/28 06:39:04 UTC
[GitHub] [pulsar-client-go] faycheng opened a new pull request #372: [Issue 367][producer] Send delay message individually even batching is enabled
faycheng opened a new pull request #372:
URL: https://github.com/apache/pulsar-client-go/pull/372
Fixes #367
### Motivation
Send delay message individually even batching is enabled.
### Modifications
1. flush batching messages immediately when a new delay message is received
2. reset all message metadata of `BatchBuilder`
### Verifying this change
Ref #367
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy merged pull request #372: [Issue 367][producer] Send delay message individually even batching is enabled
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #372:
URL: https://github.com/apache/pulsar-client-go/pull/372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy merged pull request #372: [Issue 367][producer] Send delay message individually even batching is enabled
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #372:
URL: https://github.com/apache/pulsar-client-go/pull/372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] faycheng commented on pull request #372: [Issue 367][producer] Send delay message individually even batching is enabled
Posted by GitBox <gi...@apache.org>.
faycheng commented on pull request #372:
URL: https://github.com/apache/pulsar-client-go/pull/372#issuecomment-701318596
> @faycheng The change LGTM+1, can you add a test case for this change?
Sure.I will add a unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] faycheng closed pull request #372: [Issue 367][producer] Send delay message individually even batching is enabled
Posted by GitBox <gi...@apache.org>.
faycheng closed pull request #372:
URL: https://github.com/apache/pulsar-client-go/pull/372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org