You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Shawn Jiang (JIRA)" <ji...@apache.org> on 2009/07/20 08:05:14 UTC
[jira] Updated: (GERONIMO-4737) geronimo source code should follow
resource filtering best practice defined in genesis.
[ https://issues.apache.org/jira/browse/GERONIMO-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shawn Jiang updated GERONIMO-4737:
----------------------------------
Description:
See the filtering setting in
http://repo1.maven.org/maven2/org/apache/geronimo/genesis/genesis-default-flava/2.0/genesis-default-flava-2.0.pom
{code}
<resources>
<resource>
<directory>${project.basedir}/src/main/resources</directory>
<filtering>false</filtering>
<includes>
<include>**/*</include>
</includes>
</resource>
<resource>
<directory>${project.basedir}/src/main/filtered-resources</directory>
<filtering>true</filtering>
<includes>
<include>**/*</include>
</includes>
</resource>
</resources>
<testResources>
<testResource>
<directory>${project.basedir}/src/test/resources</directory>
<filtering>false</filtering>
<includes>
<include>**/*</include>
</includes>
</testResource>
<testResource>
<directory>${project.basedir}/src/test/filtered-resources</directory>
<filtering>true</filtering>
<includes>
<include>**/*</include>
</includes>
</testResource>
</testResources>
{code}
was:
geronimo-commands has is own filter setting in pom.xml. The settings have conflicts:
{code}
<resources>
<resource>
<directory>${pom.basedir}/src/main/resources</directory>
<includes>
<include>**/*</include>
</includes>
</resource>
<resource>
<directory>${pom.basedir}/src/main/resources</directory>
<filtering>true</filtering>
<includes>
<include>org/apache/geronimo/commands/version.properties</include>
</includes>
</resource>
{code}
One is <filtering>false</filtering>, the other is <filtering>true</filtering>. This will result in filter setting merge error sometime.
Issue Type: Improvement (was: Bug)
Summary: geronimo source code should follow resource filtering best practice defined in genesis. (was: geronimo-commands module should inherit filter settings from genesis.)
The attached patch only for all
${project.basedir}/src/main/
Will provide the patch to all
${project.basedir}/src/test/
after the first patch is proved stable.
> geronimo source code should follow resource filtering best practice defined in genesis.
> ---------------------------------------------------------------------------------------
>
> Key: GERONIMO-4737
> URL: https://issues.apache.org/jira/browse/GERONIMO-4737
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: buildsystem
> Affects Versions: 2.2
> Reporter: Shawn Jiang
> Assignee: Shawn Jiang
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4737_filter_svn_commands_patch.txt, G4737_trunk
>
>
> See the filtering setting in
> http://repo1.maven.org/maven2/org/apache/geronimo/genesis/genesis-default-flava/2.0/genesis-default-flava-2.0.pom
> {code}
> <resources>
> <resource>
> <directory>${project.basedir}/src/main/resources</directory>
> <filtering>false</filtering>
> <includes>
> <include>**/*</include>
> </includes>
> </resource>
> <resource>
> <directory>${project.basedir}/src/main/filtered-resources</directory>
> <filtering>true</filtering>
> <includes>
> <include>**/*</include>
> </includes>
> </resource>
> </resources>
> <testResources>
> <testResource>
> <directory>${project.basedir}/src/test/resources</directory>
> <filtering>false</filtering>
> <includes>
> <include>**/*</include>
> </includes>
> </testResource>
> <testResource>
> <directory>${project.basedir}/src/test/filtered-resources</directory>
> <filtering>true</filtering>
> <includes>
> <include>**/*</include>
> </includes>
> </testResource>
> </testResources>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.