You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@opennlp.apache.org by "kinow (via GitHub)" <gi...@apache.org> on 2023/02/18 08:22:18 UTC

[GitHub] [opennlp] kinow commented on a diff in pull request #502: OPENNLP-1468 Simplify test assertions in JUnit tests

kinow commented on code in PR #502:
URL: https://github.com/apache/opennlp/pull/502#discussion_r1110866692


##########
opennlp-tools/src/test/java/opennlp/tools/util/VersionTest.java:
##########
@@ -63,6 +63,6 @@ void testParseInvalidVersion2() {
       return;
     }
 
-    Assertions.assertTrue(false);
+    Assertions.fail();

Review Comment:
   :smile: that was definitely one way to make the test fail



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org