[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #20200: Refactor transaction container

[GitBox <gi...@apache.org>]

taojintianxia commented on code in PR #20200:
URL: https://github.com/apache/shardingsphere/pull/20200#discussion_r946629363


##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/src/test/java/org/apache/shardingsphere/test/integration/env/container/atomic/storage/DockerStorageContainer.java:
##########
@@ -110,24 +111,30 @@ protected void postStart() {
     public DataSource createAccessDataSource(final String dataSourceName) {
         HikariDataSource result = new HikariDataSource();
         result.setDriverClassName(DataSourceEnvironment.getDriverClassName(databaseType));
-        result.setJdbcUrl(DataSourceEnvironment.getURL(databaseType, getHost(), getMappedPort(getPort()), dataSourceName));
+        result.setJdbcUrl(getJdbcUrl(dataSourceName));
         result.setUsername(getUsername());
         result.setPassword(getUnifiedPassword());
         result.setMaximumPoolSize(4);
         result.setTransactionIsolation("TRANSACTION_READ_COMMITTED");
         return result;
     }
     
+    /**
+     * Get JDBC URL.
+     * 
+     * @param dataSourceName datasource name.

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org