[GitHub] gianm commented on a change in pull request #6493: Support for request logging in kafka emitter.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6493: Support for request logging in kafka emitter.
URL: https://github.com/apache/incubator-druid/pull/6493#discussion_r236847994
 
 

 ##########
 File path: extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitter.java
 ##########
 @@ -121,23 +131,31 @@ public void start()
   {
     scheduler.scheduleWithFixedDelay(this::sendMetricToKafka, 10, 10, TimeUnit.SECONDS);
     scheduler.scheduleWithFixedDelay(this::sendAlertToKafka, 10, 10, TimeUnit.SECONDS);
+    scheduler.scheduleWithFixedDelay(this::sendRequestToKafka, 10, 10, TimeUnit.SECONDS);
     scheduler.scheduleWithFixedDelay(() -> {
-      log.info("Message lost counter: metricLost=[%d], alertLost=[%d], invalidLost=[%d]",
-               metricLost.get(), alertLost.get(), invalidLost.get());
+      log.info("Message lost counter: metricLost=[%d], alertLost=[%d], requestLost=[%d], invalidLost=[%d]",
+               metricLost.get(), alertLost.get(), requestLost.get(), invalidLost.get());
     }, 5, 5, TimeUnit.MINUTES);
     log.info("Starting Kafka Emitter.");
   }
 
   private void sendMetricToKafka()
   {
+
     sendToKafka(config.getMetricTopic(), metricQueue);
   }
 
   private void sendAlertToKafka()
   {
+
 
 Review comment:
   This extra line seems unintentional, too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org