[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #11619: Add meta data metrics about schema count and database count

[GitBox <gi...@apache.org>]

taojintianxia commented on a change in pull request #11619:
URL: https://github.com/apache/shardingsphere/pull/11619#discussion_r682291784



##########
File path: shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/test/java/org/apache/shardingsphere/agent/metrics/api/fixture/FixtureWrapper.java
##########
@@ -29,52 +29,27 @@
     private Double fixtureValue = 0.0d;
     
     @Override
-    public void counterInc(final long value) {
+    public void inc(final double value) {
         fixtureValue += value;
     }
     
     @Override
-    public void counterInc() {
-        counterInc(1L);
-    }
-
-    @Override
-    public void counterInc(final long value, final String... labels) {
-        fixtureValue += value;
-    }
-
-    @Override
-    public void counterInc(final String... labels) {
-        counterInc(1, labels);
-    }
-
-    @Override
-    public void gaugeInc() {
-        gaugeInc(1L);
-    }
-    
-    @Override
-    public void gaugeInc(final double value) {
+    public void inc(final double value, final String... labels) {
         fixtureValue += value;
     }
-
-    @Override
-    public void gaugeDec() {
-        gaugeDec(1L);
-    }
     
     @Override
-    public void gaugeDec(final double value) {
+    public void dec(final double value) {
         fixtureValue -= value;
     }
     
     @Override
-    public void histogramObserve(final double value) {        
-        fixtureValue = value;
+    public void dec(final double value, final String... labels) {
+        fixtureValue -= value;
     }
     
     @Override
-    public void summaryObserve(final double value) {
+    public void observe(final double value) {        

Review comment:
       is that a useless tab ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org