[GitHub] [spark] grundprinzip commented on a diff in pull request #37993: [SPARK-40557][CONNECT] Update generated proto files for Spark Connect

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #37993:
URL: https://github.com/apache/spark/pull/37993#discussion_r988554994


##########
python/pyspark/sql/connect/proto/base_pb2.py:
##########
@@ -28,26 +28,20 @@
 _sym_db = _symbol_database.Default()
 
 
-from pyspark.sql.connect.proto import (
-    commands_pb2 as spark_dot_connect_dot_commands__pb2,
-)
-from pyspark.sql.connect.proto import (
-    relations_pb2 as spark_dot_connect_dot_relations__pb2,
-)
+from pyspark.sql.connect.proto import commands_pb2 as spark_dot_connect_dot_commands__pb2

Review Comment:
   In contrast to Java in Python the generated code is the final artifact. The only way to achieve this would be to use a proper build system for Python but that's probably going to be a much bigger task.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org