[GitHub] [spark] xinrong-meng commented on a diff in pull request #40244: [WIP][SPARK-42643][CONNECT][PYTHON] Implement `spark.udf.registerJavaFunction`

["xinrong-meng (via GitHub)" <gi...@apache.org>]

xinrong-meng commented on code in PR #40244:
URL: https://github.com/apache/spark/pull/40244#discussion_r1125939747


##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -303,14 +303,15 @@ message Expression {
 message CommonInlineUserDefinedFunction {
   // (Required) Name of the user-defined function.
   string function_name = 1;
-  // (Required) Indicate if the user-defined function is deterministic.
+  // (Optional) Indicate if the user-defined function is deterministic.
   bool deterministic = 2;

Review Comment:
   JavaUDF has no `deterministic` field but the server doesn't have logic that relies on that field. So only the comment is changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org