You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/31 07:15:54 UTC

[GitHub] [incubator-seatunnel-website] zhongjiajie opened a new pull request #101: [doc] Change document order

zhongjiajie opened a new pull request #101:
URL: https://github.com/apache/incubator-seatunnel-website/pull/101


   We reorder our document in this path and move next
   release after `1.x(not apache release)` and before
   all versions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel-website] CalvinKirs merged pull request #101: [doc] Change document order

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #101:
URL: https://github.com/apache/incubator-seatunnel-website/pull/101


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel-website] zhongjiajie commented on a change in pull request #101: [doc] Change document order

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #101:
URL: https://github.com/apache/incubator-seatunnel-website/pull/101#discussion_r839259922



##########
File path: src/pages/home/index.jsx
##########
@@ -30,7 +32,8 @@ export default function () {
                         <p className="main_slogan">{dataSource.home.banner.slogan}</p>
 
                         <div className="button_row center">
-                            <a href="https://seatunnel.apache.org/docs/category/start" className="corner_button blue_fill">{dataSource.common.getStart}</a>
+                            {/* TODO next release should be change to /category/start */}
+                            <a href={'/docs/' + versions[0] + '/introduction'} className="corner_button blue_fill">{dataSource.common.getStart}</a>

Review comment:
       But we have to change it to `/category/start` in the next release docs, so I add some todo mark here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel-website] zhongjiajie commented on a change in pull request #101: [doc] Change document order

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #101:
URL: https://github.com/apache/incubator-seatunnel-website/pull/101#discussion_r839258878



##########
File path: src/pages/home/index.jsx
##########
@@ -30,7 +32,8 @@ export default function () {
                         <p className="main_slogan">{dataSource.home.banner.slogan}</p>
 
                         <div className="button_row center">
-                            <a href="https://seatunnel.apache.org/docs/category/start" className="corner_button blue_fill">{dataSource.common.getStart}</a>
+                            {/* TODO next release should be change to /category/start */}
+                            <a href={'/docs/' + versions[0] + '/introduction'} className="corner_button blue_fill">{dataSource.common.getStart}</a>

Review comment:
       I make it jump to our latest release version docment




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel-website] CalvinKirs commented on a change in pull request #101: [doc] Change document order

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #101:
URL: https://github.com/apache/incubator-seatunnel-website/pull/101#discussion_r839265586



##########
File path: src/pages/home/index.jsx
##########
@@ -30,7 +32,8 @@ export default function () {
                         <p className="main_slogan">{dataSource.home.banner.slogan}</p>
 
                         <div className="button_row center">
-                            <a href="https://seatunnel.apache.org/docs/category/start" className="corner_button blue_fill">{dataSource.common.getStart}</a>
+                            {/* TODO next release should be change to /category/start */}
+                            <a href={'/docs/' + versions[0] + '/introduction'} className="corner_button blue_fill">{dataSource.common.getStart}</a>

Review comment:
       ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org