[GitHub] [druid] tejaswini-imply commented on a diff in pull request #13144: Adds Idle feature to `SeekableStreamSupervisor` for inactive stream

[GitBox <gi...@apache.org>]

tejaswini-imply commented on code in PR #13144:
URL: https://github.com/apache/druid/pull/13144#discussion_r983960094


##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -2502,11 +2538,48 @@ private boolean updatePartitionDataFromStream()
     return true;
   }
 
+  public long computeTotalLag()
+  {
+    if (isIdle()) {
+      Map<PartitionIdType, SequenceOffsetType> oldOffsets = getOffsetsFromMetadataStorage();
+      return computeLagStatsForOffsets(oldOffsets).getTotalLag();

Review Comment:
   @AmatyaAvadhanula Thanks for the review, I have addressed your comments in the latest commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org