You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Zakharov (JIRA)" <ji...@apache.org> on 2006/10/30 17:22:17 UTC

[jira] Created: (HARMONY-2011) [classlib][beans] refactoring of PersistenceDelegateTest (2)

[classlib][beans] refactoring of PersistenceDelegateTest (2)
------------------------------------------------------------

                 Key: HARMONY-2011
                 URL: http://issues.apache.org/jira/browse/HARMONY-2011
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
         Environment: ws2003
            Reporter: Alexei Zakharov
            Priority: Minor


This is the final rework of org.apache.harmony.beans.tests.java.beans.PersistenceDelegateTest. The attached patch fixes problems in following tests:

testInitialize_Normal
testInitialize_NullInstances
testInitialize_NullEncoder
Tests were refactored; all calls to CallVerificationStack (a reverse engineering toolkit) were removed. Now test logic is clear and obvious.

testInitialize_circularRedundancy
I added this test to check the specific case when a circular redundancy is possible. RI handles it ok.

MockEncoder and MockPersistenceDelegate internal classes were removed since no one is using it currently. 

BTW, all tests from the PersistenceDelegateTest class are enabled now; therefore we can remove the class from the exclude list.

Thanks.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2011) [classlib][beans] refactoring of PersistenceDelegateTest (2)

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2011?page=all ]

Alexei Zakharov updated HARMONY-2011:
-------------------------------------

    Attachment: HY2011-PersistenceDelegateTest.patch

> [classlib][beans] refactoring of PersistenceDelegateTest (2)
> ------------------------------------------------------------
>
>                 Key: HARMONY-2011
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2011
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: ws2003
>            Reporter: Alexei Zakharov
>            Priority: Minor
>         Attachments: HY2011-PersistenceDelegate.patch, HY2011-PersistenceDelegateTest.patch
>
>
> This is the final rework of org.apache.harmony.beans.tests.java.beans.PersistenceDelegateTest. The attached patch fixes problems in following tests:
> testInitialize_Normal
> testInitialize_NullInstances
> testInitialize_NullEncoder
> Tests were refactored; all calls to CallVerificationStack (a reverse engineering toolkit) were removed. Now test logic is clear and obvious.
> testInitialize_circularRedundancy
> I added this test to check the specific case when a circular redundancy is possible. RI handles it ok.
> MockEncoder and MockPersistenceDelegate internal classes were removed since no one is using it currently. 
> BTW, all tests from the PersistenceDelegateTest class are enabled now; therefore we can remove the class from the exclude list.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2011) [classlib][beans] refactoring of PersistenceDelegateTest (2)

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2011?page=all ]

Alexei Zakharov updated HARMONY-2011:
-------------------------------------

    Attachment: HY2011-PersistenceDelegate.patch

> [classlib][beans] refactoring of PersistenceDelegateTest (2)
> ------------------------------------------------------------
>
>                 Key: HARMONY-2011
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2011
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: ws2003
>            Reporter: Alexei Zakharov
>            Priority: Minor
>         Attachments: HY2011-PersistenceDelegate.patch, HY2011-PersistenceDelegateTest.patch
>
>
> This is the final rework of org.apache.harmony.beans.tests.java.beans.PersistenceDelegateTest. The attached patch fixes problems in following tests:
> testInitialize_Normal
> testInitialize_NullInstances
> testInitialize_NullEncoder
> Tests were refactored; all calls to CallVerificationStack (a reverse engineering toolkit) were removed. Now test logic is clear and obvious.
> testInitialize_circularRedundancy
> I added this test to check the specific case when a circular redundancy is possible. RI handles it ok.
> MockEncoder and MockPersistenceDelegate internal classes were removed since no one is using it currently. 
> BTW, all tests from the PersistenceDelegateTest class are enabled now; therefore we can remove the class from the exclude list.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-2011) [classlib][beans] refactoring of PersistenceDelegateTest (2)

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2011?page=all ]

Tim Ellison resolved HARMONY-2011.
----------------------------------

    Resolution: Fixed

Thanks Alexei.

Patch applied (and test enabled) in BEANS module at repo revision r469219.

Please check that the patch was applied as you expected.



> [classlib][beans] refactoring of PersistenceDelegateTest (2)
> ------------------------------------------------------------
>
>                 Key: HARMONY-2011
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2011
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: ws2003
>            Reporter: Alexei Zakharov
>         Assigned To: Tim Ellison
>            Priority: Minor
>         Attachments: HY2011-PersistenceDelegate.patch, HY2011-PersistenceDelegateTest.patch
>
>
> This is the final rework of org.apache.harmony.beans.tests.java.beans.PersistenceDelegateTest. The attached patch fixes problems in following tests:
> testInitialize_Normal
> testInitialize_NullInstances
> testInitialize_NullEncoder
> Tests were refactored; all calls to CallVerificationStack (a reverse engineering toolkit) were removed. Now test logic is clear and obvious.
> testInitialize_circularRedundancy
> I added this test to check the specific case when a circular redundancy is possible. RI handles it ok.
> MockEncoder and MockPersistenceDelegate internal classes were removed since no one is using it currently. 
> BTW, all tests from the PersistenceDelegateTest class are enabled now; therefore we can remove the class from the exclude list.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-2011) [classlib][beans] refactoring of PersistenceDelegateTest (2)

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2011?page=all ]

Tim Ellison reassigned HARMONY-2011:
------------------------------------

    Assignee: Tim Ellison

> [classlib][beans] refactoring of PersistenceDelegateTest (2)
> ------------------------------------------------------------
>
>                 Key: HARMONY-2011
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2011
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: ws2003
>            Reporter: Alexei Zakharov
>         Assigned To: Tim Ellison
>            Priority: Minor
>         Attachments: HY2011-PersistenceDelegate.patch, HY2011-PersistenceDelegateTest.patch
>
>
> This is the final rework of org.apache.harmony.beans.tests.java.beans.PersistenceDelegateTest. The attached patch fixes problems in following tests:
> testInitialize_Normal
> testInitialize_NullInstances
> testInitialize_NullEncoder
> Tests were refactored; all calls to CallVerificationStack (a reverse engineering toolkit) were removed. Now test logic is clear and obvious.
> testInitialize_circularRedundancy
> I added this test to check the specific case when a circular redundancy is possible. RI handles it ok.
> MockEncoder and MockPersistenceDelegate internal classes were removed since no one is using it currently. 
> BTW, all tests from the PersistenceDelegateTest class are enabled now; therefore we can remove the class from the exclude list.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-2011) [classlib][beans] refactoring of PersistenceDelegateTest (2)

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2011?page=all ]

Tim Ellison closed HARMONY-2011.
--------------------------------


Verified by Alexei.


> [classlib][beans] refactoring of PersistenceDelegateTest (2)
> ------------------------------------------------------------
>
>                 Key: HARMONY-2011
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2011
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: ws2003
>            Reporter: Alexei Zakharov
>         Assigned To: Tim Ellison
>            Priority: Minor
>         Attachments: HY2011-PersistenceDelegate.patch, HY2011-PersistenceDelegateTest.patch
>
>
> This is the final rework of org.apache.harmony.beans.tests.java.beans.PersistenceDelegateTest. The attached patch fixes problems in following tests:
> testInitialize_Normal
> testInitialize_NullInstances
> testInitialize_NullEncoder
> Tests were refactored; all calls to CallVerificationStack (a reverse engineering toolkit) were removed. Now test logic is clear and obvious.
> testInitialize_circularRedundancy
> I added this test to check the specific case when a circular redundancy is possible. RI handles it ok.
> MockEncoder and MockPersistenceDelegate internal classes were removed since no one is using it currently. 
> BTW, all tests from the PersistenceDelegateTest class are enabled now; therefore we can remove the class from the exclude list.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2011) [classlib][beans] refactoring of PersistenceDelegateTest (2)

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2011?page=comments#action_12445866 ] 
            
Alexei Zakharov commented on HARMONY-2011:
------------------------------------------

Looks good, thanks Tim. It would be great if you can look at HARMONY-1884 also, since the patches are overlapping already (in messages.properties).

> [classlib][beans] refactoring of PersistenceDelegateTest (2)
> ------------------------------------------------------------
>
>                 Key: HARMONY-2011
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2011
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: ws2003
>            Reporter: Alexei Zakharov
>         Assigned To: Tim Ellison
>            Priority: Minor
>         Attachments: HY2011-PersistenceDelegate.patch, HY2011-PersistenceDelegateTest.patch
>
>
> This is the final rework of org.apache.harmony.beans.tests.java.beans.PersistenceDelegateTest. The attached patch fixes problems in following tests:
> testInitialize_Normal
> testInitialize_NullInstances
> testInitialize_NullEncoder
> Tests were refactored; all calls to CallVerificationStack (a reverse engineering toolkit) were removed. Now test logic is clear and obvious.
> testInitialize_circularRedundancy
> I added this test to check the specific case when a circular redundancy is possible. RI handles it ok.
> MockEncoder and MockPersistenceDelegate internal classes were removed since no one is using it currently. 
> BTW, all tests from the PersistenceDelegateTest class are enabled now; therefore we can remove the class from the exclude list.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2011) [classlib][beans] refactoring of PersistenceDelegateTest (2)

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2011?page=comments#action_12445885 ] 
            
Alexei Zakharov commented on HARMONY-2011:
------------------------------------------

Oh, sorry not HARMONY-1884 but HARMONY-1827. 

> [classlib][beans] refactoring of PersistenceDelegateTest (2)
> ------------------------------------------------------------
>
>                 Key: HARMONY-2011
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2011
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: ws2003
>            Reporter: Alexei Zakharov
>         Assigned To: Tim Ellison
>            Priority: Minor
>         Attachments: HY2011-PersistenceDelegate.patch, HY2011-PersistenceDelegateTest.patch
>
>
> This is the final rework of org.apache.harmony.beans.tests.java.beans.PersistenceDelegateTest. The attached patch fixes problems in following tests:
> testInitialize_Normal
> testInitialize_NullInstances
> testInitialize_NullEncoder
> Tests were refactored; all calls to CallVerificationStack (a reverse engineering toolkit) were removed. Now test logic is clear and obvious.
> testInitialize_circularRedundancy
> I added this test to check the specific case when a circular redundancy is possible. RI handles it ok.
> MockEncoder and MockPersistenceDelegate internal classes were removed since no one is using it currently. 
> BTW, all tests from the PersistenceDelegateTest class are enabled now; therefore we can remove the class from the exclude list.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira