You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/03 00:54:21 UTC

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #9824: style(mypy): enforcing mypy typing for superset.connectors module

serenajiang commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r434251806



##########
File path: superset/utils/core.py
##########
@@ -256,8 +259,6 @@ def parse_human_datetime(s: Optional[str]) -> Optional[datetime]:
     >>> year_ago_1 == year_ago_2
     True
     """
-    if not s:

Review comment:
       FOUND IT. @john-bodley 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org