You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by codecov on 2023/01/30 17:36:21 UTC
[GitHub] [superset] codecov[bot] commented on pull request #22910: chore: Migrate /superset/estimate_query_cost/// to API v1
codecov[bot] commented on PR #22910:
URL: https://github.com/apache/superset/pull/22910#issuecomment-1409041175
# [Codecov](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22910](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e6e356) into [master](https://codecov.io/gh/apache/superset/commit/c839d0daf50af4e974572b3a261eae5582951bbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c839d0d) will **increase** coverage by `0.06%`.
> The diff coverage is `97.36%`.
> :exclamation: Current head 5e6e356 differs from pull request most recent head a4ec247. Consider uploading reports for the commit a4ec247 to get more accurate results
```diff
@@ Coverage Diff @@
## master #22910 +/- ##
==========================================
+ Coverage 65.81% 65.88% +0.06%
==========================================
Files 1876 1877 +1
Lines 72086 72144 +58
Branches 7872 7869 -3
==========================================
+ Hits 47447 47533 +86
+ Misses 22619 22593 -26
+ Partials 2020 2018 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `?` | |
| postgres | `78.80% <100.00%> (+0.04%)` | :arrow_up: |
| presto | `52.62% <56.75%> (?)` | |
| python | `78.96% <100.00%> (+0.11%)` | :arrow_up: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.65% <0.00%> (+0.16%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `36.87% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/sqllab/api.py](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/sqllab/commands/estimate.py](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2NvbW1hbmRzL2VzdGltYXRlLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sqllab/schemas.py](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.41% <100.00%> (-0.21%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `75.00% <0.00%> (-17.86%)` | :arrow_down: |
| [.../src/utils/getChartRequiredFieldsMissingMessage.ts](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENoYXJ0UmVxdWlyZWRGaWVsZHNNaXNzaW5nTWVzc2FnZS50cw==) | `66.66% <0.00%> (-13.34%)` | :arrow_down: |
| [superset/common/utils/dataframe\_utils.py](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3V0aWxzL2RhdGFmcmFtZV91dGlscy5weQ==) | `80.95% <0.00%> (-4.77%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/superset/pull/22910?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org