You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2008/02/19 04:24:27 UTC
svn commit: r628978 - /tapestry/tapestry5/trunk/src/site/apt/dev/bible.apt
Author: hlship
Date: Mon Feb 18 19:22:54 2008
New Revision: 628978
URL: http://svn.apache.org/viewvc?rev=628978&view=rev
Log:
TAPESTRY-2147: Typo in Tapestry developer "bible"
Modified:
tapestry/tapestry5/trunk/src/site/apt/dev/bible.apt
Modified: tapestry/tapestry5/trunk/src/site/apt/dev/bible.apt
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/src/site/apt/dev/bible.apt?rev=628978&r1=628977&r2=628978&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/src/site/apt/dev/bible.apt (original)
+++ tapestry/tapestry5/trunk/src/site/apt/dev/bible.apt Mon Feb 18 19:22:54 2008
@@ -60,8 +60,11 @@
* Closing bugs
- Is it a bug fix without tests? <<No.>> In some cases, I write bugs to provide an issue is not valid and leave
- the tests in place. A good plan is to write a test that fails then work the code until the test passes.
+ Is it a bug fix without tests? <<No.>> In some cases, I write new tests to prove that an issue is not valid and
+ then leave
+ the tests in place -- the close the bug as invalid.
+
+ A good plan is to write a test that fails then work the code until the test passes.
I'm also surprised by how often code works in a unit test but fails unexpectedly in an integration test.
As the G-Man says, <"Expect unforseen consequences">.
@@ -81,7 +84,19 @@
Close the issue but <<make sure the fix release is blank>>. Otherwise, the issue <<will be listed
in the release notes>>, which we don't want.
-
+
+Copyrights
+
+ The ASF copyright must appear on all Java source files. Technically it should appear on all non-binary
+ files in the repository.
+
+ As you make changes to files, update the copyright to add the current year to the list. The goal is that the copyright
+ notice includes the year in which files change. When creating a new file, don't back date the copyright year ... start
+ with the current year. Try not to change the copyright year on files that haven't actually changed.
+
+ IntelliJ has a great comparison view: Cmd-9 to see the local changes, the Cmd-D to see the differences.
+ I whip through the changes (using Cmd-forward arrow) and make sure copyrights are up to date as I review the changes
+ prior to a commit.
Public vs. Private/Internal