You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/06/01 11:47:13 UTC
[GitHub] [netbeans] sdedic commented on a change in pull request #2984: Completion items imported from Java delegate to ElementJavadoc to get the content.
sdedic commented on a change in pull request #2984:
URL: https://github.com/apache/netbeans/pull/2984#discussion_r643027843
##########
File path: groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/completion/CompletionItem.java
##########
@@ -910,30 +955,18 @@ public boolean equals(Object obj) {
}
}
- public static class JavaFieldItem extends CompletionItem {
-
- private final String className;
- private final String name;
+ public static class JavaFieldItem extends JavaElementItem {
Review comment:
@JaroslavTulach I'll better rework the change - it'd prefer not to introduce any API changes at all :-/ Those APIs are too open already. Sorry for the inconvenience - you'll be reviewing once more ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists