You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/02 07:23:23 UTC
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (369afd4) into [master](https://codecov.io/gh/apache/superset/commit/8ebec6016ecd0b729ff149bf1bb051da808f3f95?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ebec60) will **increase** coverage by `9.79%`.
> The diff coverage is `54.00%`.
> :exclamation: Current head 369afd4 differs from pull request most recent head eba9e97. Consider uploading reports for the commit eba9e97 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
+ Coverage 67.10% 76.89% +9.79%
==========================================
Files 1609 1045 -564
Lines 64897 55698 -9199
Branches 6866 7606 +740
==========================================
- Hits 43547 42830 -717
+ Misses 19484 12618 -6866
+ Partials 1866 250 -1616
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <54.00%> (+17.17%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <ø> (+10.71%)` | :arrow_up: |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `42.10% <42.10%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `57.89% <57.89%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `96.00% <66.66%> (+5.67%)` | :arrow_up: |
| ... and [1270 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8ebec60...eba9e97](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org