You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "zhaoyajun2009 (via GitHub)" <gi...@apache.org> on 2024/03/06 01:34:08 UTC
[PR] The sample configuration of io-debezium has a error of parameter. [pulsar-site]
zhaoyajun2009 opened a new pull request, #825:
URL: https://github.com/apache/pulsar-site/pull/825
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
-->
<!-- Either this PR adds a doc for a code PR, -->
This PR adds doc for #xyz
<!-- or fixes a doc issue -->
This PR fixes #xyz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] The sample configuration of io-debezium has an error of parameter. [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle merged PR #825:
URL: https://github.com/apache/pulsar-site/pull/825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] The sample configuration of io-debezium has an error of parameter. [pulsar-site]
Posted by "zhaoyajun2009 (via GitHub)" <gi...@apache.org>.
zhaoyajun2009 commented on code in PR #825:
URL: https://github.com/apache/pulsar-site/pull/825#discussion_r1515583152
##########
docs/io-cdc-debezium.md:
##########
@@ -80,7 +80,7 @@ You can use one of the following methods to create a configuration file.
tenant: "public"
namespace: "default"
name: "debezium-mysql-source"
- inputs: [ "debezium-mysql-topic" ]
+ topicName: "debezium-mysql-topic"
Review Comment:
if config this topicName，it create the topic as follow：
`persistent://public/default/debezium-mysql-topic3333333333333333333333333333333333-partition-0`
the logs is printed as follow：
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] The sample configuration of io-debezium has an error of parameter. [pulsar-site]
Posted by "zhaoyajun2009 (via GitHub)" <gi...@apache.org>.
zhaoyajun2009 commented on code in PR #825:
URL: https://github.com/apache/pulsar-site/pull/825#discussion_r1515583152
##########
docs/io-cdc-debezium.md:
##########
@@ -80,7 +80,7 @@ You can use one of the following methods to create a configuration file.
tenant: "public"
namespace: "default"
name: "debezium-mysql-source"
- inputs: [ "debezium-mysql-topic" ]
+ topicName: "debezium-mysql-topic"
Review Comment:
if config this topicName，it create the topic as follows ,this function is corect.
`persistent://public/default/debezium-mysql-topic3333333333333333333333333333333333-partition-0`
the logs is printed as follows：
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] The sample configuration of io-debezium has an error of parameter. [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on PR #825:
URL: https://github.com/apache/pulsar-site/pull/825#issuecomment-1980647894
I suppose the PR author is right here: https://github.com/apache/pulsar/blob/e2f94dc98dbecb4dc401ba837c54f497ca9d896f/pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/io/SourceConfig.java#L43
But it would be good if someone else took a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] The sample configuration of io-debezium has an error of parameter. [pulsar-site]
Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd commented on code in PR #825:
URL: https://github.com/apache/pulsar-site/pull/825#discussion_r1515310543
##########
docs/io-cdc-debezium.md:
##########
@@ -80,7 +80,7 @@ You can use one of the following methods to create a configuration file.
tenant: "public"
namespace: "default"
name: "debezium-mysql-source"
- inputs: [ "debezium-mysql-topic" ]
+ topicName: "debezium-mysql-topic"
Review Comment:
In fact, the CDC Debezium Source connector does not use this configuration, but sends data to the pulsar topic according to this rule.
```
The topic naming rule is: "{{database.server.name}}.{{table.name}}". For examples: "public/default/mydbserver.public.io-test".You can also choose to use a variety of other tools to create a connector:
```
We should remove this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] The sample configuration of io-debezium has an error of parameter. [pulsar-site]
Posted by "zhaoyajun2009 (via GitHub)" <gi...@apache.org>.
zhaoyajun2009 commented on code in PR #825:
URL: https://github.com/apache/pulsar-site/pull/825#discussion_r1515583152
##########
docs/io-cdc-debezium.md:
##########
@@ -80,7 +80,7 @@ You can use one of the following methods to create a configuration file.
tenant: "public"
namespace: "default"
name: "debezium-mysql-source"
- inputs: [ "debezium-mysql-topic" ]
+ topicName: "debezium-mysql-topic"
Review Comment:
if config this topicName，it create the topic as follows ,this function is correct.
`persistent://public/default/debezium-mysql-topic3333333333333333333333333333333333-partition-0`
the logs is printed as follows：
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] The sample configuration of io-debezium has an error of parameter. [pulsar-site]
Posted by "zhaoyajun2009 (via GitHub)" <gi...@apache.org>.
zhaoyajun2009 commented on PR #825:
URL: https://github.com/apache/pulsar-site/pull/825#issuecomment-1982475252
> I suppose the PR author is right here: https://github.com/apache/pulsar/blob/e2f94dc98dbecb4dc401ba837c54f497ca9d896f/pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/io/SourceConfig.java#L43
>
> Strangely, this mistake went unnoticed for a long time. It would be good if someone else took a look.
> I suppose the PR author is right here: https://github.com/apache/pulsar/blob/e2f94dc98dbecb4dc401ba837c54f497ca9d896f/pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/io/SourceConfig.java#L43
>
> Strangely, this mistake went unnoticed for a long time. It would be good if someone else took a look.
because the parameter of "inputs" is in the SinkConfig, it is caused by copying.
https://github.com/apache/pulsar/blob/e2f94dc98dbecb4dc401ba837c54f497ca9d896f/pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/io/SinkConfig.java#L49C39-L50C1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] The sample configuration of io-debezium has an error of parameter. [pulsar-site]
Posted by "zhaoyajun2009 (via GitHub)" <gi...@apache.org>.
zhaoyajun2009 commented on code in PR #825:
URL: https://github.com/apache/pulsar-site/pull/825#discussion_r1515539866
##########
docs/io-cdc-debezium.md:
##########
@@ -80,7 +80,7 @@ You can use one of the following methods to create a configuration file.
tenant: "public"
namespace: "default"
name: "debezium-mysql-source"
- inputs: [ "debezium-mysql-topic" ]
+ topicName: "debezium-mysql-topic"
Review Comment:
if remove this line，the process of testing is unable to function properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] The sample configuration of io-debezium has an error of parameter. [pulsar-site]
Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd commented on code in PR #825:
URL: https://github.com/apache/pulsar-site/pull/825#discussion_r1515766377
##########
docs/io-cdc-debezium.md:
##########
@@ -80,7 +80,7 @@ You can use one of the following methods to create a configuration file.
tenant: "public"
namespace: "default"
name: "debezium-mysql-source"
- inputs: [ "debezium-mysql-topic" ]
+ topicName: "debezium-mysql-topic"
Review Comment:
I remember that I didn't need to fill in this name in my previous test, and you can refer to the [this docs](https://docs.streamnative.io/hub/connector-debezium-postgres-source-v3.1).
whatever, there will be no problem with the configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] The sample configuration of io-debezium has an error of parameter. [pulsar-site]
Posted by "zhaoyajun2009 (via GitHub)" <gi...@apache.org>.
zhaoyajun2009 commented on code in PR #825:
URL: https://github.com/apache/pulsar-site/pull/825#discussion_r1515539866
##########
docs/io-cdc-debezium.md:
##########
@@ -80,7 +80,7 @@ You can use one of the following methods to create a configuration file.
tenant: "public"
namespace: "default"
name: "debezium-mysql-source"
- inputs: [ "debezium-mysql-topic" ]
+ topicName: "debezium-mysql-topic"
Review Comment:
if remove this line，the process of testing is unable to function properly，the binlog is not source to pulsar's topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] The sample configuration of io-debezium has an error of parameter. [pulsar-site]
Posted by "zhaoyajun2009 (via GitHub)" <gi...@apache.org>.
zhaoyajun2009 commented on code in PR #825:
URL: https://github.com/apache/pulsar-site/pull/825#discussion_r1515583152
##########
docs/io-cdc-debezium.md:
##########
@@ -80,7 +80,7 @@ You can use one of the following methods to create a configuration file.
tenant: "public"
namespace: "default"
name: "debezium-mysql-source"
- inputs: [ "debezium-mysql-topic" ]
+ topicName: "debezium-mysql-topic"
Review Comment:
if config this topicName，it create the topic as follow ,this function is corect.
`persistent://public/default/debezium-mysql-topic3333333333333333333333333333333333-partition-0`
the logs is printed as follow：
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org