[GitHub] [incubator-superset] etr2460 opened a new pull request #8182: [Config] Disable celery acks late

[GitBox <gi...@apache.org>]

etr2460 opened a new pull request #8182: [Config] Disable celery acks late
URL: https://github.com/apache/incubator-superset/pull/8182
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   We should not enable `CELERY_ACKS_LATE` because our tasks are not guaranteed to be idempotent (see here for details: https://docs.celeryproject.org/en/latest/userguide/tasks.html#tasks).
   
   This setting was also causing issues as we'd see a single SQL Lab query fire off duplicate queries to Presto that would then be killed to protect Presto from duplicate queries.
   
   ### TEST PLAN
   Config was tested and async queries still work as before
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @john-bodley @graceguo-supercat @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org