[GitHub] [zeppelin] felixcheung commented on a change in pull request #3342: [ZEPPELIN-4031] Fixed Unable to detect that the interpreter process was killed manually

[GitBox <gi...@apache.org>]

felixcheung commented on a change in pull request #3342: [ZEPPELIN-4031] Fixed Unable to detect that the interpreter process was killed manually
URL: https://github.com/apache/zeppelin/pull/3342#discussion_r268959898
 
 

 ##########
 File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/ManagedInterpreterGroup.java
 ##########
 @@ -141,17 +165,27 @@ private void close(Collection<Interpreter> interpreters) {
   private void closeInterpreter(Interpreter interpreter) {
     Scheduler scheduler = interpreter.getScheduler();
 
-    for (final Job job : scheduler.getAllJobs()) {
-      job.abort();
-      job.setStatus(Job.Status.ABORT);
-      LOGGER.info("Job " + job.getJobName() + " aborted ");
-    }
+    // Need to abort the task being executed
+    // when actively shutting down the remote interpreter
+    if (false == remoteIntpProcessIsShutdown()) {
 
 Review comment:
   this isn't quite I'd expected... if the process is created but it's not running, yes it could be being shutdown else where but it could also be that it was killed or crashed or something. in the latter case, shouldn't it go ahead to abort the jobs anyway?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services