[GitHub] [ignite] avplatonov commented on a change in pull request #6853: IGNITE-12024: [ML] PeerClassloading for ml related lambdas

[GitBox <gi...@apache.org>]

avplatonov commented on a change in pull request #6853: IGNITE-12024: [ML] PeerClassloading for ml related lambdas
URL: https://github.com/apache/ignite/pull/6853#discussion_r322000494
 
 

 ##########
 File path: modules/ml/src/main/java/org/apache/ignite/ml/composition/ModelsComposition.java
 ##########
 @@ -23,13 +23,15 @@
 import org.apache.ignite.ml.Exporter;
 import org.apache.ignite.ml.IgniteModel;
 import org.apache.ignite.ml.composition.predictionsaggregator.PredictionsAggregator;
+import org.apache.ignite.ml.environment.deploy.DeployableObject;
 import org.apache.ignite.ml.math.primitives.vector.Vector;
 import org.apache.ignite.ml.util.ModelTrace;
 
 /**
  * Model consisting of several models and prediction aggregation strategy.
  */
-public class ModelsComposition implements IgniteModel<Vector, Double>, Exportable<ModelsCompositionFormat> {
+public class ModelsComposition implements IgniteModel<Vector, Double>, Exportable<ModelsCompositionFormat>,
 
 Review comment:
   I'm not sure, there is a child of this class (GDBModel) and I don't want to change an inheritance schema in this PR. Maybe we should create another ticker in Jira with a review of hierarchies of models (of course without changing APIs) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services