You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/01/16 20:19:57 UTC
Review Request 55590: Add common log rotation settings to HDFS,
Zookeeper configs - addendum
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55590/
-----------------------------------------------------------
Review request for Ambari and Sumit Mohanty.
Bugs: AMBARI-18814 and AMBARI-19274
https://issues.apache.org/jira/browse/AMBARI-18814
https://issues.apache.org/jira/browse/AMBARI-19274
Repository: ambari
Description
-------
Default value for hdfs maxbackupindex was originally 10, https://reviews.apache.org/r/54760/ changed it to 20.
Default value for zookeeper maxfilesize and maxbackupindex was originally 10, https://reviews.apache.org/r/54955/ changed it to 256 and 20 respectively.
Made appropriate corrections in this patch.
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml 52f166d
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 3725bc0
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 0f3a2c4
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-log4j.xml 7bdb938
Diff: https://reviews.apache.org/r/55590/diff/
Testing
-------
Run unitTests
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 55590: Add common log rotation settings to HDFS,
Zookeeper configs - addendum
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
> On Jan. 20, 2017, 7:15 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml, line 56
> > <https://reviews.apache.org/r/55590/diff/1/?file=1605973#file1605973line56>
> >
> > Please also modify HDFS 3.0.0.3.0 in common services, before-START hook for HDP 3.0
> >
> > Will this Jira address changing these values during an EU/RU?
Hi,
The 20 is changed to 10 because 20 was put incorrectly as part of https://reviews.apache.org/r/54760/.
The params file already has 10 as the value.
Upgrade packs already have the value as 10.
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55590/#review162468
-----------------------------------------------------------
On Jan. 20, 2017, 6:44 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55590/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 6:44 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-19656
> https://issues.apache.org/jira/browse/AMBARI-19656
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Default value for hdfs maxbackupindex was originally 10, https://reviews.apache.org/r/54760/ changed it to 20.
> Default value for zookeeper maxfilesize and maxbackupindex was originally 10, https://reviews.apache.org/r/54955/ changed it to 256 and 20 respectively.
> Made appropriate corrections in this patch.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml 52f166d
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 3725bc0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 0f3a2c4
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-log4j.xml 7bdb938
>
> Diff: https://reviews.apache.org/r/55590/diff/
>
>
> Testing
> -------
>
> Run unitTests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 55590: Add common log rotation settings to HDFS,
Zookeeper configs - addendum
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55590/#review162468
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml (line 56)
<https://reviews.apache.org/r/55590/#comment233797>
Please also modify HDFS 3.0.0.3.0 in common services, before-START hook for HDP 3.0
Will this Jira address changing these values during an EU/RU?
- Alejandro Fernandez
On Jan. 20, 2017, 6:44 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55590/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 6:44 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-19656
> https://issues.apache.org/jira/browse/AMBARI-19656
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Default value for hdfs maxbackupindex was originally 10, https://reviews.apache.org/r/54760/ changed it to 20.
> Default value for zookeeper maxfilesize and maxbackupindex was originally 10, https://reviews.apache.org/r/54955/ changed it to 256 and 20 respectively.
> Made appropriate corrections in this patch.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml 52f166d
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 3725bc0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 0f3a2c4
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-log4j.xml 7bdb938
>
> Diff: https://reviews.apache.org/r/55590/diff/
>
>
> Testing
> -------
>
> Run unitTests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 55590: Add common log rotation settings to HDFS,
Zookeeper configs - addendum
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55590/
-----------------------------------------------------------
(Updated Jan. 20, 2017, 6:44 p.m.)
Review request for Ambari and Sumit Mohanty.
Changes
-------
Created a new Apache jira for this patch.
Bugs: AMBARI-19656
https://issues.apache.org/jira/browse/AMBARI-19656
Repository: ambari
Description
-------
Default value for hdfs maxbackupindex was originally 10, https://reviews.apache.org/r/54760/ changed it to 20.
Default value for zookeeper maxfilesize and maxbackupindex was originally 10, https://reviews.apache.org/r/54955/ changed it to 256 and 20 respectively.
Made appropriate corrections in this patch.
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml 52f166d
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 3725bc0
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 0f3a2c4
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-log4j.xml 7bdb938
Diff: https://reviews.apache.org/r/55590/diff/
Testing
-------
Run unitTests
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 55590: Add common log rotation settings to HDFS,
Zookeeper configs - addendum
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55590/#review161943
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Jan. 16, 2017, 8:19 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55590/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2017, 8:19 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-18814 and AMBARI-19274
> https://issues.apache.org/jira/browse/AMBARI-18814
> https://issues.apache.org/jira/browse/AMBARI-19274
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Default value for hdfs maxbackupindex was originally 10, https://reviews.apache.org/r/54760/ changed it to 20.
> Default value for zookeeper maxfilesize and maxbackupindex was originally 10, https://reviews.apache.org/r/54955/ changed it to 256 and 20 respectively.
> Made appropriate corrections in this patch.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml 52f166d
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 3725bc0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 0f3a2c4
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-log4j.xml 7bdb938
>
> Diff: https://reviews.apache.org/r/55590/diff/
>
>
> Testing
> -------
>
> Run unitTests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>