You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/20 03:33:17 UTC
[GitHub] [flink] banmoy commented on a change in pull request #6275:
[FLINK-9776] [runtime] Stop sending periodic interrupts once executing
thread leaves user function / operator code.
banmoy commented on a change in pull request #6275: [FLINK-9776] [runtime] Stop sending periodic interrupts once executing thread leaves user function / operator code.
URL: https://github.com/apache/flink/pull/6275#discussion_r348277532
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1514,8 +1517,10 @@ public void run() {
}
}
- // send the initial interruption signal
- executer.interrupt();
+ // send the initial interruption signal, if requested
+ if (invokable.shouldInterruptOnCancel()) {
+ executer.interrupt();
Review comment:
This interrupt could also slip through in the case as StefanRRichter mentioned above. Why not use a locked code block to guarantee it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services