You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sgilmore10 (via GitHub)" <gi...@apache.org> on 2023/05/08 19:12:43 UTC
[GitHub] [arrow] sgilmore10 opened a new pull request, #35491: GH-35480: [MATLAB] [3:05 PM] Add abstract MATLAB base class called `arrow.array.Array`
sgilmore10 opened a new pull request, #35491:
URL: https://github.com/apache/arrow/pull/35491
> **Warning** This pull request is dependent upon #35479. We will rebase and mark as ready for reviewer once that one is merged.
### Rationale for this change
It will be helpful for sharing the implementation of common functionality if there is an abstract base class from which the MATLAB `arrow.array.[Type]Array` classes can inherit.
### What changes are included in this PR?
1. Added abstract base class `arrow.array.Array`
2. Changed `arrow.array.Float64Array` to inherit from `arrow.array.Array`
3. Added `Length` property on `arrow.array.Array`
### Are these changes tested?
1. Added a test point for the `Length` property in `tFloat64Array.m`.
2. Qualified locally on macOS and linux.
### Are there any user-facing changes?
Yes, there is now a `Length` property on `arrow.array.Float64Array`
### Future Directions
We will continue to build out the concrete Array subclasses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35491: GH-35480: [MATLAB] Add abstract MATLAB base class called `arrow.array.Array`
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35491:
URL: https://github.com/apache/arrow/pull/35491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sgilmore10 commented on pull request #35491: GH-35480: [MATLAB] Add abstract MATLAB base class called `arrow.array.Array`
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #35491:
URL: https://github.com/apache/arrow/pull/35491#issuecomment-1542273837
Marking PR as read for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35491: GH-35480: [MATLAB] Add abstract MATLAB base class called `arrow.array.Array`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35491:
URL: https://github.com/apache/arrow/pull/35491#issuecomment-1538906897
* Closes: #35480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35491: GH-35480: [MATLAB] Add abstract MATLAB base class called `arrow.array.Array`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35491:
URL: https://github.com/apache/arrow/pull/35491#issuecomment-1546734929
Benchmark runs are scheduled for baseline = 14f9bf923a5655c04130a2db0cabe15a0249dd79 and contender = cdefbb8f4b4183b29fbcdb014af1f6fc0030475c. cdefbb8f4b4183b29fbcdb014af1f6fc0030475c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1b5ded494dbf4f65b43328362c7fcca7...7054d55c20f04309b3ed289c6cf34f2b/)
[Finished :arrow_down:2.27% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/50c295200bba44638ef77492ba2de447...7a4b9c4fd3af4ebc8f54b3fc66423c8e/)
[Finished :arrow_down:0.25% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/80cbe13b10ca4d39b05e59e4b4d5037d...fa87d1c4beda4b5ebe8f2968029587c3/)
[Finished :arrow_down:0.42% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d6109567cf5e4da597c3d982ccbfe5d6...7c97de048f7342ba88514d57efbd1e04/)
Buildkite builds:
[Finished] [`cdefbb8f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2866)
[Finished] [`cdefbb8f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2903)
[Finished] [`cdefbb8f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2868)
[Finished] [`cdefbb8f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2893)
[Finished] [`14f9bf92` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2863)
[Finished] [`14f9bf92` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2891)
[Finished] [`14f9bf92` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2855)
[Finished] [`14f9bf92` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2882)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org