You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/21 11:35:52 UTC
[GitHub] [spark] HeartSaVioR opened a new pull request #35599: [SPARK-38206][SS] Ignore nullability on comparing the data type of join keys on stream-stream join
HeartSaVioR opened a new pull request #35599:
URL: https://github.com/apache/spark/pull/35599
### What changes were proposed in this pull request?
This PR proposes to change the assertion of data type against joining keys on stream-stream join to ignore nullability.
### Why are the changes needed?
The existing requirement on checking data types of joining keys is too restricted, as it also requires the same nullability. In batch query (I checked with HashJoinExec), nullability is ignored when checking data types of joining keys.
### Does this PR introduce _any_ user-facing change?
Yes, end users will no longer encounter the assertion error on join keys with different nullability in both keys.
### How was this patch tested?
New test added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #35599: [SPARK-38206][SS] Ignore nullability on comparing the data type of join keys on stream-stream join
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #35599:
URL: https://github.com/apache/spark/pull/35599#issuecomment-1047270436
cc. @cloud-fan @viirya @xuanyuanking @c21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #35599: [SPARK-38206][SS] Ignore nullability on comparing the data type of join keys on stream-stream join
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #35599:
URL: https://github.com/apache/spark/pull/35599#issuecomment-1047481249
Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #35599: [SPARK-38206][SS] Ignore nullability on comparing the data type of join keys on stream-stream join
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #35599:
URL: https://github.com/apache/spark/pull/35599#issuecomment-1046830576
I've added test cases for inner & left-outer join. I guess it's redundant to have separate test cases for right-outer/full-outer/left-semi, but please let me know if we would like to have exhausive set of tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR closed pull request #35599: [SPARK-38206][SS] Ignore nullability on comparing the data type of join keys on stream-stream join
Posted by GitBox <gi...@apache.org>.
HeartSaVioR closed pull request #35599:
URL: https://github.com/apache/spark/pull/35599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #35599: [SPARK-38206][SS] Ignore nullability on comparing the data type of join keys on stream-stream join
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #35599:
URL: https://github.com/apache/spark/pull/35599#issuecomment-1048092896
Sorry for late comment, just late +1 LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org