You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/10/05 21:43:13 UTC

[royale-asjs] branch develop updated: jewel-combobox: remove timeout to open and make faster opacity animation. We improve over 400ms when popup the combobox internal list

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 10c1e6e  jewel-combobox: remove timeout to open and make faster opacity animation. We improve over 400ms when popup the combobox internal list
10c1e6e is described below

commit 10c1e6e59fe99e825900e85953a4c86651ec2e85
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Mon Oct 5 23:43:02 2020 +0200

    jewel-combobox: remove timeout to open and make faster opacity animation. We improve over 400ms when popup the combobox internal list
---
 frameworks/projects/Jewel/src/main/resources/defaults.css              | 2 +-
 .../main/royale/org/apache/royale/jewel/beads/views/ComboBoxView.as    | 3 ++-
 frameworks/projects/Jewel/src/main/sass/components/_combobox.sass      | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/frameworks/projects/Jewel/src/main/resources/defaults.css b/frameworks/projects/Jewel/src/main/resources/defaults.css
index 7c3c1c4..1a4e940 100644
--- a/frameworks/projects/Jewel/src/main/resources/defaults.css
+++ b/frameworks/projects/Jewel/src/main/resources/defaults.css
@@ -451,7 +451,7 @@ j|ComboBox {
 }
 .combobox-popup.open .jewel.list {
   transform: translate(-50%, -100%);
-  transition: transform 0.4s 0ms, opacity 0.4s 0ms;
+  transition: transform 0.3s 0ms, opacity 0.3s 0ms;
   opacity: 1;
 }
 
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ComboBoxView.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ComboBoxView.as
index c46bdaf..99445e5 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ComboBoxView.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ComboBoxView.as
@@ -217,7 +217,8 @@ package org.apache.royale.jewel.beads.views
 
 					window.addEventListener('resize', autoResizeHandler, false);
                     }
-                    setTimeout(prepareForPopUp,  300);
+                    
+					prepareForPopUp();
 
 					sendStrandEvent(_strand, "popUpOpened");
 
diff --git a/frameworks/projects/Jewel/src/main/sass/components/_combobox.sass b/frameworks/projects/Jewel/src/main/sass/components/_combobox.sass
index 57ae3b3..bc59d57 100644
--- a/frameworks/projects/Jewel/src/main/sass/components/_combobox.sass
+++ b/frameworks/projects/Jewel/src/main/sass/components/_combobox.sass
@@ -113,7 +113,7 @@ $combobox-item-min-heigh: 34px
 
         .jewel.list
             transform: translate(-50%, -100%)
-            transition: animation-standard(transform, .4s), animation-standard(opacity, .4s)
+            transition: animation-standard(transform, .3s), animation-standard(opacity, .3s)
             opacity: 1
 
 @media (max-width: ($tablet - 1))