You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/09 07:02:01 UTC
[GitHub] [apisix-dashboard] imjoey opened a new pull request #1250: chore: Improve the http body check in e2e test case
imjoey opened a new pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250
Signed-off-by: imjoey <ma...@gmail.com>
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
Fixes #1246 .
___
Changes proposed in this PR:
1. Change the name of `UnexpectedBody` property to `UnexpectBody` to get along with `ExpectBody` field;
2. Set the types of `ExpectBody` and `UnexpectBody ` to `interface{}`, to add support for checking on multiple strings. See #1246 for details. Also use this new feature to refactor the test case of `server_info_test.go` to reduce time cost;
3. Fix a logical bug. Previously, if the `ExpectBody` is set as `""`, the check will be certainly ignored. While actually I believe this purpose is to expect the body be empty. Please see https://github.com/apache/apisix-dashboard/blob/93b9765e3e77c6cefe0487e1657886d5f05d4146/api/test/e2e/route_with_plugin_cors_test.go#L138-L153 as an example;
4. Other minor style fixes;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-758463860
No need to retrigger Update branch :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-757108053
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=h1) Report
> Merging [#1250](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=desc) (2834ae8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8ca42d48f80e2214df452a86f996ce39932a8ed1?el=desc) (8ca42d4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1250 +/- ##
=======================================
Coverage 42.44% 42.44%
=======================================
Files 31 31
Lines 1932 1932
=======================================
Hits 820 820
Misses 1001 1001
Partials 111 111
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=footer). Last update [8ca42d4...2834ae8](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#discussion_r554656529
##########
File path: api/test/e2e/server_info_test.go
##########
@@ -121,25 +112,14 @@ func TestServerInfo_Get_OmitEmptyValue(t *testing.T) {
func TestServerInfo_List_OmitEmptyValue(t *testing.T) {
testCases := []HttpTestCase{
{
- Desc: "list all server info",
- Object: ManagerApiExpect(t),
- Path: "/apisix/admin/server_info",
- Method: http.MethodGet,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- ExpectBody: "\"total_size\":2",
- UnexpectedBody: "\"create_time\":",
- },
- {
- Desc: "list server info with hostname",
- Object: ManagerApiExpect(t),
- Path: "/apisix/admin/server_info",
- Query: "hostname=apisix_",
- Method: http.MethodGet,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- ExpectBody: "\"total_size\":2",
- UnexpectedBody: "\"update_time\":",
Review comment:
Hi, why delete this test?
This test is for `list server info with hostname`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-757108053
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=h1) Report
> Merging [#1250](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=desc) (0cc4784) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b2908468d4c8df96bde32c088710a2ee7fae67a9?el=desc) (b290846) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1250 +/- ##
==========================================
- Coverage 42.44% 42.39% -0.06%
==========================================
Files 31 31
Lines 1932 1932
==========================================
- Hits 820 819 -1
- Misses 1001 1002 +1
Partials 111 111
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1250/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.37% <0.00%> (-0.63%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=footer). Last update [b290846...0cc4784](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-757108053
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=h1) Report
> Merging [#1250](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=desc) (4045d2e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/93b9765e3e77c6cefe0487e1657886d5f05d4146?el=desc) (93b9765) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1250 +/- ##
=======================================
Coverage 42.44% 42.44%
=======================================
Files 31 31
Lines 1932 1932
=======================================
Hits 820 820
Misses 1001 1001
Partials 111 111
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=footer). Last update [93b9765...4045d2e](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-757110430
ping @starsz @juzhiyuan for review. Any feedback is welcome. Much appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#discussion_r554658409
##########
File path: api/test/e2e/server_info_test.go
##########
@@ -121,25 +112,14 @@ func TestServerInfo_Get_OmitEmptyValue(t *testing.T) {
func TestServerInfo_List_OmitEmptyValue(t *testing.T) {
testCases := []HttpTestCase{
{
- Desc: "list all server info",
- Object: ManagerApiExpect(t),
- Path: "/apisix/admin/server_info",
- Method: http.MethodGet,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- ExpectBody: "\"total_size\":2",
- UnexpectedBody: "\"create_time\":",
- },
- {
- Desc: "list server info with hostname",
- Object: ManagerApiExpect(t),
- Path: "/apisix/admin/server_info",
- Query: "hostname=apisix_",
- Method: http.MethodGet,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- ExpectBody: "\"total_size\":2",
- UnexpectedBody: "\"update_time\":",
Review comment:
@starsz PR renewed with restoring the mistakenly removed code, much appreciated for your reviewing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-757108053
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=h1) Report
> Merging [#1250](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=desc) (8e9609a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0f322e1d4a03e3416da1ae989fcfa49232035648?el=desc) (0f322e1) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1250 +/- ##
=======================================
Coverage 42.44% 42.44%
=======================================
Files 31 31
Lines 1932 1932
=======================================
Hits 820 820
Misses 1001 1001
Partials 111 111
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=footer). Last update [0f322e1...8e9609a](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-757108053
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=h1) Report
> Merging [#1250](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=desc) (4045d2e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/93b9765e3e77c6cefe0487e1657886d5f05d4146?el=desc) (93b9765) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1250 +/- ##
=======================================
Coverage 42.44% 42.44%
=======================================
Files 31 31
Lines 1932 1932
=======================================
Hits 820 820
Misses 1001 1001
Partials 111 111
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=footer). Last update [93b9765...4045d2e](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-757108053
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=h1) Report
> Merging [#1250](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=desc) (3c51fe5) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b2908468d4c8df96bde32c088710a2ee7fae67a9?el=desc) (b290846) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1250 +/- ##
=======================================
Coverage 42.44% 42.44%
=======================================
Files 31 31
Lines 1932 1932
=======================================
Hits 820 820
Misses 1001 1001
Partials 111 111
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=footer). Last update [b290846...3c51fe5](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-758463731
This PR will get merged after https://github.com/apache/apisix-dashboard/pull/1272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#discussion_r554657429
##########
File path: api/test/e2e/server_info_test.go
##########
@@ -121,25 +112,14 @@ func TestServerInfo_Get_OmitEmptyValue(t *testing.T) {
func TestServerInfo_List_OmitEmptyValue(t *testing.T) {
testCases := []HttpTestCase{
{
- Desc: "list all server info",
- Object: ManagerApiExpect(t),
- Path: "/apisix/admin/server_info",
- Method: http.MethodGet,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- ExpectBody: "\"total_size\":2",
- UnexpectedBody: "\"create_time\":",
- },
- {
- Desc: "list server info with hostname",
- Object: ManagerApiExpect(t),
- Path: "/apisix/admin/server_info",
- Query: "hostname=apisix_",
- Method: http.MethodGet,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- ExpectBody: "\"total_size\":2",
- UnexpectedBody: "\"update_time\":",
Review comment:
@starsz oh, sorry, my bad. Will restore it soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-758465022
> No need to retrigger Update branch :)
@juzhiyuan OK. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-757110430
ping @starsz @juzhiyuan for review. Any feedback is welcome. Much appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1250: chore: Improve the http body check in e2e test case
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1250:
URL: https://github.com/apache/apisix-dashboard/pull/1250#issuecomment-757108053
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=h1) Report
> Merging [#1250](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=desc) (ee1d609) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/61f7c210baa21c65f0fa46dc0f1301ee96ccd7a5?el=desc) (61f7c21) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1250 +/- ##
==========================================
- Coverage 42.44% 42.39% -0.06%
==========================================
Files 31 31
Lines 1932 1932
==========================================
- Hits 820 819 -1
- Misses 1001 1002 +1
Partials 111 111
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1250/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.37% <0.00%> (-0.63%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=footer). Last update [d6dcaa4...d9b417d](https://codecov.io/gh/apache/apisix-dashboard/pull/1250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org