You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/22 20:13:26 UTC
[GitHub] [nifi] markap14 opened a new pull request, #6236: NIFI-10262: Ensure that when an Exception is thrown from a Controller…
markap14 opened a new pull request, #6236:
URL: https://github.com/apache/nifi/pull/6236
… Service's @OnEnabled method that we properly handle that Exception and continue enabling the other services in the given collection of services
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6236: NIFI-10262: Ensure that when an Exception is thrown from a Controller…
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6236:
URL: https://github.com/apache/nifi/pull/6236#issuecomment-1193011608
@markap14 after taking a closer look, apparently the rebase resulted in code changes resulting from the merge of NIFI-10246 in PR #6219. Although the merge did not produce any Git conflicts, it resulted in making `StandardControllerServiceProvider` invalid. I restored the `else` block added in NIFI-10246 to the `disableControllerServices()` method and force-pushed changes to the branch.
That change should allow the build process to move forward, but I will avoid making any additional changes and let you confirm that the current state of this branch reflects the original changes intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #6236: NIFI-10262: Ensure that when an Exception is thrown from a Controller…
Posted by GitBox <gi...@apache.org>.
markap14 commented on PR #6236:
URL: https://github.com/apache/nifi/pull/6236#issuecomment-1194156412
Ah, wow. Good catch. All looks good to me. Thanks @exceptionfactory !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6236: NIFI-10262: Ensure that when an Exception is thrown from a Controller…
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6236:
URL: https://github.com/apache/nifi/pull/6236#issuecomment-1192953021
The automated build failures seem specific to the GitHub runner. Will rebase on current main branch to see that resolves the issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6236: NIFI-10262: Ensure that when an Exception is thrown from a Controller…
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6236: NIFI-10262: Ensure that when an Exception is thrown from a Controller…
URL: https://github.com/apache/nifi/pull/6236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org